From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buKBX-00026E-EA for qemu-devel@nongnu.org; Wed, 12 Oct 2016 10:07:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buKBV-0005S4-HL for qemu-devel@nongnu.org; Wed, 12 Oct 2016 10:07:06 -0400 Date: Wed, 12 Oct 2016 16:06:56 +0200 From: Kevin Wolf Message-ID: <20161012140656.GJ5544@noname.redhat.com> References: <83fc54b59c1e1a729c2bb3c051b787cf4386b49a.1475757437.git.berto@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83fc54b59c1e1a729c2bb3c051b787cf4386b49a.1475757437.git.berto@igalia.com> Subject: Re: [Qemu-devel] [PATCH v10 07/16] block: Block all intermediate nodes in commit_active_start() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz , Markus Armbruster , Stefan Hajnoczi Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > When block-commit is launched without the top parameter, it uses > internally a mirror block job. In that case all intermediate nodes > between the active and base nodes must be blocked as well. > > Signed-off-by: Alberto Garcia Same as the patch before, dataplane is okay because AioContexts are switched together with the source image. On second thought, however, maybe both places should set a blocker that prevents attaching intermediate nodes to a new block device because you can't read consistent data there. That's a preexisting problem, though, and needs its own patch. Reviewed-by: Kevin Wolf