From: Greg Kurz <groug@kaod.org>
To: Li Qiang <liq3ea@gmail.com>
Cc: qemu-devel@nongnu.org, Li Qiang <liqiang6-s@360.cn>
Subject: Re: [Qemu-devel] [PATCH] 9pfs: fix memory leak in v9fs_link
Date: Wed, 12 Oct 2016 15:37:21 +0200 [thread overview]
Message-ID: <20161012153721.57603553@bahia> (raw)
In-Reply-To: <57fde276.652f6b0a.4ba6d.b725@mx.google.com>
On Wed, 12 Oct 2016 00:12:48 -0700
Li Qiang <liq3ea@gmail.com> wrote:
> From: Li Qiang <liqiang6-s@360.cn>
>
> In v9fs_link dispatch function, it doesn't put the 'oldfidp'
> fid object, this will make the 'oldfidp->ref' never reach to 0,
> thus leading a memory leak issue. This patch fix this.
>
> Signed-off-by: Li Qiang <liqiang6-s@360.cn>
> ---
Good catch!
Reviewed-by: Greg Kurz <groug@kaod.org>
> hw/9pfs/9p.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index 8b50bfb..29f8b7a 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -2413,6 +2413,7 @@ static void v9fs_link(void *opaque)
> if (!err) {
> err = offset;
> }
> + put_fid(pdu, oldfidp);
> out:
> put_fid(pdu, dfidp);
> out_nofid:
prev parent reply other threads:[~2016-10-12 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 7:12 [Qemu-devel] [PATCH] 9pfs: fix memory leak in v9fs_link Li Qiang
2016-10-12 13:37 ` Greg Kurz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012153721.57603553@bahia \
--to=groug@kaod.org \
--cc=liq3ea@gmail.com \
--cc=liqiang6-s@360.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).