* [Qemu-devel] [PATCH] 9pfs: fix memory leak in v9fs_link
@ 2016-10-12 7:12 Li Qiang
2016-10-12 13:37 ` Greg Kurz
0 siblings, 1 reply; 2+ messages in thread
From: Li Qiang @ 2016-10-12 7:12 UTC (permalink / raw)
To: groug, qemu-devel; +Cc: Li Qiang
From: Li Qiang <liqiang6-s@360.cn>
In v9fs_link dispatch function, it doesn't put the 'oldfidp'
fid object, this will make the 'oldfidp->ref' never reach to 0,
thus leading a memory leak issue. This patch fix this.
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
---
hw/9pfs/9p.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 8b50bfb..29f8b7a 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -2413,6 +2413,7 @@ static void v9fs_link(void *opaque)
if (!err) {
err = offset;
}
+ put_fid(pdu, oldfidp);
out:
put_fid(pdu, dfidp);
out_nofid:
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] 9pfs: fix memory leak in v9fs_link
2016-10-12 7:12 [Qemu-devel] [PATCH] 9pfs: fix memory leak in v9fs_link Li Qiang
@ 2016-10-12 13:37 ` Greg Kurz
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kurz @ 2016-10-12 13:37 UTC (permalink / raw)
To: Li Qiang; +Cc: qemu-devel, Li Qiang
On Wed, 12 Oct 2016 00:12:48 -0700
Li Qiang <liq3ea@gmail.com> wrote:
> From: Li Qiang <liqiang6-s@360.cn>
>
> In v9fs_link dispatch function, it doesn't put the 'oldfidp'
> fid object, this will make the 'oldfidp->ref' never reach to 0,
> thus leading a memory leak issue. This patch fix this.
>
> Signed-off-by: Li Qiang <liqiang6-s@360.cn>
> ---
Good catch!
Reviewed-by: Greg Kurz <groug@kaod.org>
> hw/9pfs/9p.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index 8b50bfb..29f8b7a 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -2413,6 +2413,7 @@ static void v9fs_link(void *opaque)
> if (!err) {
> err = offset;
> }
> + put_fid(pdu, oldfidp);
> out:
> put_fid(pdu, dfidp);
> out_nofid:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-12 13:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-12 7:12 [Qemu-devel] [PATCH] 9pfs: fix memory leak in v9fs_link Li Qiang
2016-10-12 13:37 ` Greg Kurz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).