qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Hao QingFeng <haoqf@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 0/3] iotests: Skip 162 if there is no SSH support
Date: Wed, 12 Oct 2016 22:49:04 +0200	[thread overview]
Message-ID: <20161012204907.25941-1-mreitz@redhat.com> (raw)

As reported by Hao QingFeng, iotest 162 is currently executed even if
qemu does not have any SSH support (which makes it fail, naturally).

Fixing that is not so trivial, because qemu-img currently does not
report modules, and SSH can be compiled as a module, so that needs to be
fixed first. While doing so, I noticed that bdrv_iterate_format() tries
to sort the list of formats, which is a bit contrary to my experience.
Turns out that needs to be fixed, too.


This series can either be applied on top of my series "iotests: Fix test
162" or just directly on master, both works (i.e. the patches in this
series do not interfere with those from that one). I still thought I'd
mention that series, if nothing else then only to get you to review that
other one. ;-)


Max Reitz (3):
  block: Fix bdrv_iterate_format() sorting
  block: Emit modules in bdrv_iterate_format()
  iotests: Skip test 162 if there is no SSH support

 block.c                | 20 +++++++++++++++++++-
 tests/qemu-iotests/162 |  3 +++
 2 files changed, 22 insertions(+), 1 deletion(-)

-- 
2.10.0

             reply	other threads:[~2016-10-12 20:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12 20:49 Max Reitz [this message]
2016-10-12 20:49 ` [Qemu-devel] [PATCH 1/3] block: Fix bdrv_iterate_format() sorting Max Reitz
2016-10-12 21:31   ` Eric Blake
2016-10-12 20:49 ` [Qemu-devel] [PATCH 2/3] block: Emit modules in bdrv_iterate_format() Max Reitz
2016-10-12 22:35   ` Eric Blake
2016-11-02 10:52   ` Hao QingFeng
2016-11-02 11:15     ` Kevin Wolf
2016-11-02 11:59       ` Hao QingFeng
2016-11-02 15:29       ` Eric Blake
2016-10-12 20:49 ` [Qemu-devel] [PATCH 3/3] iotests: Skip test 162 if there is no SSH support Max Reitz
2016-10-12 22:36   ` Eric Blake
2016-10-12 22:26 ` [Qemu-devel] [PATCH 0/3] iotests: Skip " no-reply
2016-10-28 15:13 ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161012204907.25941-1-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=haoqf@linux.vnet.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).