From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buYMy-00052R-Er for qemu-devel@nongnu.org; Thu, 13 Oct 2016 01:15:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buYMv-00085i-Th for qemu-devel@nongnu.org; Thu, 13 Oct 2016 01:15:51 -0400 Date: Thu, 13 Oct 2016 11:23:01 +1100 From: David Gibson Message-ID: <20161013002301.GF18039@umbus.fritz.box> References: <1476248933-25562-1-git-send-email-nikunj@linux.vnet.ibm.com> <1476248933-25562-2-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DO5DiztRLs659m5i" Content-Disposition: inline In-Reply-To: <1476248933-25562-2-git-send-email-nikunj@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v1 1/3] target-ppc: implement vexts[bh]2w and vexts[bhw]2d List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org, benh@kernel.crashing.org --DO5DiztRLs659m5i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 12, 2016 at 10:38:51AM +0530, Nikunj A Dadhania wrote: > Vector Extend Sign Instructions: >=20 > vextsb2w: Vector Extend Sign Byte To Word > vextsh2w: Vector Extend Sign Halfword To Word > vextsb2d: Vector Extend Sign Byte To Doubleword > vextsh2d: Vector Extend Sign Halfword To Doubleword > vextsw2d: Vector Extend Sign Word To Doubleword >=20 > Signed-off-by: Nikunj A Dadhania Applied to ppc-for-2.8, thanks. > --- > target-ppc/helper.h | 5 +++++ > target-ppc/int_helper.c | 15 +++++++++++++++ > target-ppc/translate/vmx-impl.inc.c | 5 +++++ > target-ppc/translate/vmx-ops.inc.c | 5 +++++ > 4 files changed, 30 insertions(+) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index 796ad45..04c6421 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -267,6 +267,11 @@ DEF_HELPER_3(vinsertb, void, avr, avr, i32) > DEF_HELPER_3(vinserth, void, avr, avr, i32) > DEF_HELPER_3(vinsertw, void, avr, avr, i32) > DEF_HELPER_3(vinsertd, void, avr, avr, i32) > +DEF_HELPER_2(vextsb2w, void, avr, avr) > +DEF_HELPER_2(vextsh2w, void, avr, avr) > +DEF_HELPER_2(vextsb2d, void, avr, avr) > +DEF_HELPER_2(vextsh2d, void, avr, avr) > +DEF_HELPER_2(vextsw2d, void, avr, avr) > DEF_HELPER_2(vupkhpx, void, avr, avr) > DEF_HELPER_2(vupklpx, void, avr, avr) > DEF_HELPER_2(vupkhsb, void, avr, avr) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index 202854f..5aee0a8 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -1934,6 +1934,21 @@ VEXTRACT(uw, u32) > VEXTRACT(d, u64) > #undef VEXTRACT > =20 > +#define VEXT_SIGNED(name, element, mask, cast, recast) \ > +void helper_##name(ppc_avr_t *r, ppc_avr_t *b) \ > +{ \ > + int i; \ > + VECTOR_FOR_INORDER_I(i, element) { \ > + r->element[i] =3D (recast)((cast)(b->element[i] & mask)); \ > + } \ > +} > +VEXT_SIGNED(vextsb2w, s32, UINT8_MAX, int8_t, int32_t) > +VEXT_SIGNED(vextsb2d, s64, UINT8_MAX, int8_t, int64_t) > +VEXT_SIGNED(vextsh2w, s32, UINT16_MAX, int16_t, int32_t) > +VEXT_SIGNED(vextsh2d, s64, UINT16_MAX, int16_t, int64_t) > +VEXT_SIGNED(vextsw2d, s64, UINT32_MAX, int32_t, int64_t) > +#undef VEXT_SIGNED > + > #define VSPLTI(suffix, element, splat_type) \ > void helper_vspltis##suffix(ppc_avr_t *r, uint32_t splat) \ > { \ > diff --git a/target-ppc/translate/vmx-impl.inc.c b/target-ppc/translate/v= mx-impl.inc.c > index 25cd073..c8998f3 100644 > --- a/target-ppc/translate/vmx-impl.inc.c > +++ b/target-ppc/translate/vmx-impl.inc.c > @@ -815,6 +815,11 @@ GEN_VXFORM_NOA(vclzb, 1, 28) > GEN_VXFORM_NOA(vclzh, 1, 29) > GEN_VXFORM_NOA(vclzw, 1, 30) > GEN_VXFORM_NOA(vclzd, 1, 31) > +GEN_VXFORM_NOA_2(vextsb2w, 1, 24, 16) > +GEN_VXFORM_NOA_2(vextsh2w, 1, 24, 17) > +GEN_VXFORM_NOA_2(vextsb2d, 1, 24, 24) > +GEN_VXFORM_NOA_2(vextsh2d, 1, 24, 25) > +GEN_VXFORM_NOA_2(vextsw2d, 1, 24, 26) > GEN_VXFORM_NOA_2(vctzb, 1, 24, 28) > GEN_VXFORM_NOA_2(vctzh, 1, 24, 29) > GEN_VXFORM_NOA_2(vctzw, 1, 24, 30) > diff --git a/target-ppc/translate/vmx-ops.inc.c b/target-ppc/translate/vm= x-ops.inc.c > index ac1dc9b..68cba3e 100644 > --- a/target-ppc/translate/vmx-ops.inc.c > +++ b/target-ppc/translate/vmx-ops.inc.c > @@ -215,6 +215,11 @@ GEN_VXFORM_DUAL_INV(vspltish, vinserth, 6, 13, 0x000= 00000, 0x100000, > GEN_VXFORM_DUAL_INV(vspltisw, vinsertw, 6, 14, 0x00000000, 0x100000, > PPC_ALTIVEC), > GEN_VXFORM_300_EXT(vinsertd, 6, 15, 0x100000), > +GEN_VXFORM_300_EO(vextsb2w, 0x01, 0x18, 0x10), > +GEN_VXFORM_300_EO(vextsh2w, 0x01, 0x18, 0x11), > +GEN_VXFORM_300_EO(vextsb2d, 0x01, 0x18, 0x18), > +GEN_VXFORM_300_EO(vextsh2d, 0x01, 0x18, 0x19), > +GEN_VXFORM_300_EO(vextsw2d, 0x01, 0x18, 0x1A), > GEN_VXFORM_300_EO(vctzb, 0x01, 0x18, 0x1C), > GEN_VXFORM_300_EO(vctzh, 0x01, 0x18, 0x1D), > GEN_VXFORM_300_EO(vctzw, 0x01, 0x18, 0x1E), --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --DO5DiztRLs659m5i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX/tPlAAoJEGw4ysog2bOSrVsP/178fHUY0ZRyIYxhT7oZi1B3 C73Esgq0FGCIOWU8XOYwC7Oz82QziwQ3qWeP/9OVNmwWTpT6sgeiKCsWiBQqWxjO +/R89cDKHVaIQZUvp+wo/OwdyLftGS7Zf16agYgZzyfk39Ar2m07QHOolHgy6A0d d+jVLHSnVycza88UFcYMUsMck+mJ32XV5DReQMsDQNGmlk6GvQFyOAyJrhILfgXR qg6VYsXRDJR7YWXOrMFN9VqgKq1Y5J2/9d6PMf0RYKOBbxxhKFV7+WRTy0bqy7TV 8tJTHu/1fd1i5/D48YbgAs64FVDVH4dTAIKy/2QtpKXmfwbsZMfOyQJ7+6HneE9f JYq4Nf+ZIWifsD8mTChwGYRg2AtepTkgjmRBIUvERDGS65AmOpSEF4NjWF8e7KM8 4C2g8GRsn1bX0iyJ1tEwq6Lv57az7QWxx+E6SHurHo6mFO0SSwNxrgMWeaEoX+RW l515b3FmK/pGKza7oXwxK10djXq5PBdiAQOhL1IhnTt5zQew2Hjtpz8Iy/pr5jfT g5Awu3XZk7fb6IE3G4vGGSEUj3YgfVEZ2//7Ro67G2uPS3LEcGSD+20Xeof0bGSv E/xJi8QVkKTUl5OOW5JXFVPem16qPZj3+GPofoNbXP3Aosn2OK2leNfZzk1L2R9y L6nO6qxY94CHLRrl4kks =XY1I -----END PGP SIGNATURE----- --DO5DiztRLs659m5i--