From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53320)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rkrcmar@redhat.com>) id 1bugSJ-0000ek-N6
	for qemu-devel@nongnu.org; Thu, 13 Oct 2016 09:53:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rkrcmar@redhat.com>) id 1bugSF-00046X-S1
	for qemu-devel@nongnu.org; Thu, 13 Oct 2016 09:53:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46734)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rkrcmar@redhat.com>) id 1bugSF-00045x-LM
	for qemu-devel@nongnu.org; Thu, 13 Oct 2016 09:53:51 -0400
Date: Thu, 13 Oct 2016 15:53:46 +0200
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Message-ID: <20161013135345.GA15008@potion>
References: <1476352367-69400-1-git-send-email-imammedo@redhat.com>
	<1476365047-73146-1-git-send-email-imammedo@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1476365047-73146-1-git-send-email-imammedo@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3  14/13] pc: q35: bump max_cpus to 288
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, liuxiaojian6@huawei.com, mst@redhat.com, peterx@redhat.com, kevin@koconnor.net, kraxel@redhat.com, pbonzini@redhat.com, lersek@redhat.com, chao.gao@intel.com

2016-10-13 15:24+0200, Igor Mammedov:
> along with it for machine versions 2.7 and older keep
> it at 255.
>=20
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---

Seems nicer than touching max_cpus in pc_machine_class_init(),

Reviewed-by: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>

> Forgot to inlude the last patch that
> permits using more than 255 cpus since q35-2.8 machine type
>=20
>=20
> v2:
>  - make 288 cpus available only since q35-2.8 machine type
> ---
>  hw/i386/pc_q35.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index 0b214f2..b40d19e 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -291,6 +291,7 @@ static void pc_q35_machine_options(MachineClass *m)
>      m->default_display =3D "std";
>      m->no_floppy =3D 1;
>      m->has_dynamic_sysbus =3D true;
> +    m->max_cpus =3D 288;
>  }
> =20
>  static void pc_q35_2_8_machine_options(MachineClass *m)
> @@ -306,6 +307,7 @@ static void pc_q35_2_7_machine_options(MachineClass=
 *m)
>  {
>      pc_q35_2_8_machine_options(m);
>      m->alias =3D NULL;
> +    m->max_cpus =3D 255;
>      SET_MACHINE_COMPAT(m, PC_COMPAT_2_7);
>  }
> =20
> --=20
> 2.7.4
>=20
>=20