From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53740)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rkrcmar@redhat.com>) id 1bugV1-0002Hx-Ep
	for qemu-devel@nongnu.org; Thu, 13 Oct 2016 09:56:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rkrcmar@redhat.com>) id 1bugUx-0005IF-FB
	for qemu-devel@nongnu.org; Thu, 13 Oct 2016 09:56:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41574)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rkrcmar@redhat.com>) id 1bugUx-0005HR-84
	for qemu-devel@nongnu.org; Thu, 13 Oct 2016 09:56:39 -0400
Date: Thu, 13 Oct 2016 15:56:34 +0200
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Message-ID: <20161013135634.GB15008@potion>
References: <1476352367-69400-1-git-send-email-imammedo@redhat.com>
	<1476352367-69400-14-git-send-email-imammedo@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1476352367-69400-14-git-send-email-imammedo@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 13/13] pc: require IRQ remapping and EIM
 if there could be x2APIC CPUs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, liuxiaojian6@huawei.com, mst@redhat.com, peterx@redhat.com, kevin@koconnor.net, kraxel@redhat.com, pbonzini@redhat.com, lersek@redhat.com, chao.gao@intel.com

2016-10-13 11:52+0200, Igor Mammedov:
> it would prevent starting guest with incorrect configs
> where interrupts couldn't be delivered to CPUs with
> APIC IDs > 254.

off-by-one.

> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---

Reviewed-by: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>

>  hw/i386/pc.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>=20
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 40eb43b..f7070e0 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -68,6 +68,7 @@
>  #include "qapi-visit.h"
>  #include "qom/cpu.h"
>  #include "hw/nmi.h"
> +#include "hw/i386/intel_iommu.h"
> =20
>  /* debug PC/ISA interrupts */
>  //#define DEBUG_IRQ
> @@ -1264,6 +1265,18 @@ void pc_machine_done(Notifier *notifier, void *d=
ata)
>                              sizeof(pcms->boot_cpus_le));
>          }
>      }
> +
> +    if (pcms->apic_id_limit > 255) {
> +        IntelIOMMUState *iommu =3D INTEL_IOMMU_DEVICE(x86_iommu_get_de=
fault());
> +
> +        if (!iommu || !iommu->x86_iommu.intr_supported ||
> +            iommu->intr_eim !=3D ON_OFF_AUTO_ON) {
> +            error_report("current -smp configuration requires "
> +                         "Extended Interrupt Mode enabled. "
> +                         "IOMMU should have eim=3Don option set");
> +            exit(EXIT_FAILURE);
> +        }
> +    }
>  }
> =20
>  void pc_guest_info_init(PCMachineState *pcms)
> --=20
> 2.7.4
>=20
>=20