From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bumcy-0001fv-9U for qemu-devel@nongnu.org; Thu, 13 Oct 2016 16:29:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bumcu-0000Qr-4i for qemu-devel@nongnu.org; Thu, 13 Oct 2016 16:29:19 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43993 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bumct-0000Qh-Uo for qemu-devel@nongnu.org; Thu, 13 Oct 2016 16:29:16 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9DKOe3l051413 for ; Thu, 13 Oct 2016 16:29:15 -0400 Received: from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151]) by mx0b-001b2d01.pphosted.com with ESMTP id 262c6bg1yw-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 13 Oct 2016 16:29:15 -0400 Received: from localhost by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 13 Oct 2016 14:29:14 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <20161012150733.GD15590@stefanha-x1.localdomain> References: <1475772018-27484-1-git-send-email-stefanha@redhat.com> <1475772018-27484-5-git-send-email-stefanha@redhat.com> <20161007170741.9563.75979@loki> <20161012150733.GD15590@stefanha-x1.localdomain> Date: Thu, 13 Oct 2016 15:29:02 -0500 Message-Id: <20161013202902.3777.3028@loki> Subject: Re: [Qemu-devel] [PATCH 4/4] qga: add vsock-listen method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org Quoting Stefan Hajnoczi (2016-10-12 10:07:33) > On Fri, Oct 07, 2016 at 12:07:41PM -0500, Michael Roth wrote: > > Quoting Stefan Hajnoczi (2016-10-06 11:40:18) > > > Add AF_VSOCK (virtio-vsock) support as an alternative to virtio-seria= l. > > > = > > > $ qemu-system-x86_64 -device vhost-vsock-pci,guest-cid=3D3 ... > > > (guest)# qemu-ga -m vsock-listen -p 3:1234 > > > = > > > Signed-off-by: Stefan Hajnoczi > > = > > Reviewed-by: Michael Roth > > = > > I still need to get a vsock environment set up to test with, but looks > > good other than minor comments in patch 3. > = > Linux 4.8 has the guest and vhost drivers: > = > CONFIG_VSOCKETS=3Dm > CONFIG_VIRTIO_VSOCKETS=3Dm > CONFIG_VIRTIO_VSOCKETS_COMMON=3Dm > CONFIG_VHOST_VSOCK=3Dm I still need to do some work to get this fully integrated into my test set up, but I ran these patches through some basic testing with a 4.8.0 host and 4.9 guest and everything seems to be in working order. I think Eric had some comments related to parameter parsing in patch 3, but otherwise looks good. > = > Stefan