From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buwWU-0002CZ-70 for qemu-devel@nongnu.org; Fri, 14 Oct 2016 03:03:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buwWS-0005Ed-Cr for qemu-devel@nongnu.org; Fri, 14 Oct 2016 03:03:18 -0400 Date: Fri, 14 Oct 2016 16:41:09 +1100 From: David Gibson Message-ID: <20161014054109.GO28562@umbus> References: <1476316647-9433-1-git-send-email-david@gibson.dropbear.id.au> <20161014041034.502017.26597@ex-std-node742.prod.rhcloud.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LwbuP8dfxhLLLUfV" Content-Disposition: inline In-Reply-To: <20161014041034.502017.26597@ex-std-node742.prod.rhcloud.com> Subject: Re: [Qemu-devel] [PATCHv3 0/7] Improve PCI IO window orgnaization for pseries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: famz@redhat.com, lvivier@redhat.com, agraf@suse.de, mst@redhat.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org, abologna@redhat.com --LwbuP8dfxhLLLUfV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 13, 2016 at 09:10:38PM -0700, no-reply@patchew.org wrote: > Hi, >=20 > Your series seems to have some coding style problems. See output below for > more information: So.. this one is a fairly standard false positive. checkpatch complains about multiple statements in a macro when it's actually a macro that's supposed to expand within a data structure initializer. > Type: series > Message-id: 1476316647-9433-1-git-send-email-david@gibson.dropbear.id.au > Subject: [Qemu-devel] [PATCHv3 0/7] Improve PCI IO window orgnaization fo= r pseries >=20 > =3D=3D=3D TEST SCRIPT BEGIN =3D=3D=3D > #!/bin/bash >=20 > BASE=3Dbase > n=3D1 > total=3D$(git log --oneline $BASE.. | wc -l) > failed=3D0 >=20 > # Useful git options > git config --local diff.renamelimit 0 > git config --local diff.renames True >=20 > commits=3D"$(git log --format=3D%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git show --no-patch --format=3D%s $= c)..." > if ! git show $c --format=3Demail | ./scripts/checkpatch.pl --mailbac= k -; then > failed=3D1 > echo > fi > n=3D$((n+1)) > done >=20 > exit $failed > =3D=3D=3D TEST SCRIPT END =3D=3D=3D >=20 > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > 8fa0718 spapr: Improved placement of PCI host bridges in guest memory map > 6416268 spapr_pci: Add a 64-bit MMIO window > 94e8f4c spapr: Adjust placement of PCI host bridge to allow > 1TiB RAM > 692718a spapr_pci: Delegate placement of PCI host bridges to machine type > 2b765c9 libqos: Limit spapr-pci to 32-bit MMIO for now > 4543692 libqos: Correct error in PCI hole sizing for spapr > 2c35727 libqos: Isolate knowledge of spapr memory map to qpci_init_spapr() >=20 > =3D=3D=3D OUTPUT BEGIN =3D=3D=3D > Checking PATCH 1/7: libqos: Isolate knowledge of spapr memory map to qpci= _init_spapr()... > Checking PATCH 2/7: libqos: Correct error in PCI hole sizing for spapr... > Checking PATCH 3/7: libqos: Limit spapr-pci to 32-bit MMIO for now... > Checking PATCH 4/7: spapr_pci: Delegate placement of PCI host bridges to = machine type... > Checking PATCH 5/7: spapr: Adjust placement of PCI host bridge to allow >= 1TiB RAM... > Checking PATCH 6/7: spapr_pci: Add a 64-bit MMIO window... > ERROR: trailing whitespace > #237: FILE: include/hw/ppc/spapr.h:44: > + uint64_t *buid, hwaddr *pio, $ >=20 > total: 1 errors, 0 warnings, 170 lines checked >=20 > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. In attempting to follow the suggestion above, I discovered that checkpatch has no listed maintainer. Maybe we should change that message to "if any of these errors are false positives, then too bad, suck it up"... --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --LwbuP8dfxhLLLUfV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYAG/1AAoJEGw4ysog2bOS/oMP+wR9x5ufzrZdxCESC3hFiYTS aFh2a1GfTRmJGg2ZX99RDNQH8y+RKIB1vWsrCVjYe7x3RMre69o7N9cM5lh1Y2Yx Dc+3V/uMWIBbXfjNUVAb5ECzoCUAq47bPiYdLH8h2ZHAGCdT4KKkSRifI7GXs9NZ ndoTMxFqJckTJZMNWes/QweWXjh0RlivVRIYGA1qJJtJmxhyW7yZnXTvDtdWXK40 PqRw+41VdjAfPYg8ek5Xd7UTEN1ANZY/7Ft+P8YkYQh0tg3M7DdyuoPPO1oIF1jT aToT3UvXSpwJYjtNPlgl0MR6m1PJunhaKvd4Wta1SrqzRBRuYMhAQWe4exPk3Lga hlnBl8uwyJSHvCeZzopIbZXRqkvfg3oeA52/mltiiaDIiM0ff67hqemwdEP1vPzV EuxXWTJr+gD606FkZ1U4+2SBbgtRmBq3sOTjL9zBZIhOf/iH4eMXXbugnWSW19xm AdA9l6ulyKLpe3MmZ7Y8V8gw0A/dRhMa00fwgSdOthzRs5TR2LGRYpK3VY84MQeX 1osztmla0r/HbzlQaMJQ7C4tWYNoTDkC2zhFV2K/3w6CUVI18dGonxW3eJIc4lPz 06Wgv73oO4VZlsfyuMSj5L8148ObCvkg7l/vcVTiTLtmUl/FgJH5VPxG4gscH6Nh dUcz/ysRE7jYgA/x/szU =JVBU -----END PGP SIGNATURE----- --LwbuP8dfxhLLLUfV--