From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buwWT-0002CW-Lq for qemu-devel@nongnu.org; Fri, 14 Oct 2016 03:03:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buwWQ-0005DN-Bw for qemu-devel@nongnu.org; Fri, 14 Oct 2016 03:03:17 -0400 Date: Fri, 14 Oct 2016 16:43:40 +1100 From: David Gibson Message-ID: <20161014054340.GP28562@umbus> References: <1476314039-9520-1-git-send-email-mdroth@linux.vnet.ibm.com> <20161014041017.502016.70581@ex-std-node742.prod.rhcloud.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="K8zN2sh9fO5jmbe4" Content-Disposition: inline In-Reply-To: <20161014041017.502016.70581@ex-std-node742.prod.rhcloud.com> Subject: Re: [Qemu-devel] [RFC PATCH 00/11] spapr: option vector re-work and memory unplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, famz@redhat.com, nfont@linux.vnet.ibm.com, qemu-ppc@nongnu.org, jallen@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com --K8zN2sh9fO5jmbe4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 13, 2016 at 09:10:22PM -0700, no-reply@patchew.org wrote: > Hi, >=20 > Your series seems to have some coding style problems. See output below for > more information: checkpatch generates a fair few false positives. However, having had a look, these don't appear to be so. >=20 > Subject: [Qemu-devel] [RFC PATCH 00/11] spapr: option vector re-work and = memory unplug support > Type: series > Message-id: 1476314039-9520-1-git-send-email-mdroth@linux.vnet.ibm.com >=20 > =3D=3D=3D TEST SCRIPT BEGIN =3D=3D=3D > #!/bin/bash >=20 > BASE=3Dbase > n=3D1 > total=3D$(git log --oneline $BASE.. | wc -l) > failed=3D0 >=20 > # Useful git options > git config --local diff.renamelimit 0 > git config --local diff.renames True >=20 > commits=3D"$(git log --format=3D%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git show --no-patch --format=3D%s $= c)..." > if ! git show $c --format=3Demail | ./scripts/checkpatch.pl --mailbac= k -; then > failed=3D1 > echo > fi > n=3D$((n+1)) > done >=20 > exit $failed > =3D=3D=3D TEST SCRIPT END =3D=3D=3D >=20 > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > b6c6ecd spapr: Memory hot-unplug support > 74753f0 spapr: use count+index for memory hotplug > 2de1399 spapr: Add DRC count indexed hotplug identifier type > 860a9e5 spapr_events: add support for dedicated hotplug event source > 895d1aa spapr: add hotplug interrupt machine options > fffa858 spapr: update spapr hotplug documentation > e9df226 spapr: fix inheritance chain for default machine options > dc9b8b1 spapr: improve ibm, architecture-vec-5 property handling > be26f44 spapr: add option vector handling in CAS-generated resets > cc5d859 spapr_hcall: use spapr_ovec_* interfaces for CAS options > 90daf38 spapr_ovec: initial implementation of option vector helpers >=20 > =3D=3D=3D OUTPUT BEGIN =3D=3D=3D > Checking PATCH 1/11: spapr_ovec: initial implementation of option vector = helpers... > WARNING: architecture specific defines should be avoided > #338: FILE: include/hw/ppc/spapr_ovec.h:36: > +#if !defined(__HW_SPAPR_OPTION_VECTORS_H__) =2E.. uh, except for this one. I think this one can be ignored, the rest should be addressed. > total: 0 errors, 1 warnings, 314 lines checked >=20 > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > Checking PATCH 2/11: spapr_hcall: use spapr_ovec_* interfaces for CAS opt= ions... > Checking PATCH 3/11: spapr: add option vector handling in CAS-generated r= esets... > Checking PATCH 4/11: spapr: improve ibm, architecture-vec-5 property hand= ling... > Checking PATCH 5/11: spapr: fix inheritance chain for default machine opt= ions... > Checking PATCH 6/11: spapr: update spapr hotplug documentation... > Checking PATCH 7/11: spapr: add hotplug interrupt machine options... > Checking PATCH 8/11: spapr_events: add support for dedicated hotplug even= t source... > ERROR: switch and case should be at the same indent > #164: FILE: hw/ppc/spapr_events.c:283: > + switch (log_type) { > + case RTAS_LOG_TYPE_HOTPLUG: > [...] > + case RTAS_LOG_TYPE_EPOW: > [...] > + default: >=20 > total: 1 errors, 0 warnings, 272 lines checked >=20 > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. >=20 > Checking PATCH 9/11: spapr: Add DRC count indexed hotplug identifier type= =2E.. > WARNING: line over 80 characters > #85: FILE: hw/ppc/spapr_events.c:538: > + hp->drc_id.count_indexed.count =3D cpu_to_be32(drc_id->count_ind= exed.count); >=20 > WARNING: line over 80 characters > #86: FILE: hw/ppc/spapr_events.c:539: > + hp->drc_id.count_indexed.index =3D cpu_to_be32(drc_id->count_ind= exed.index); >=20 > total: 0 errors, 2 warnings, 144 lines checked >=20 > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > Checking PATCH 10/11: spapr: use count+index for memory hotplug... > WARNING: line over 80 characters > #58: FILE: hw/ppc/spapr.c:2265: > + addr_start / SPAPR_MEMORY_BLO= CK_SIZE); >=20 > WARNING: line over 80 characters > #64: FILE: hw/ppc/spapr.c:2271: > + spapr_hotplug_req_add_by_count(SPAPR_DR_CONNECTOR_TYPE_LMB, = nr_lmbs); >=20 > total: 0 errors, 2 warnings, 45 lines checked >=20 > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > Checking PATCH 11/11: spapr: Memory hot-unplug support... > =3D=3D=3D OUTPUT END =3D=3D=3D >=20 > Test command exited with code: 1 >=20 >=20 > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-devel@freelists.org --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --K8zN2sh9fO5jmbe4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYAHCLAAoJEGw4ysog2bOSuCsQAJZKxXJRTqGnNqC/1e4D28UY i+CHiesBlzrkVhqdvsB8FKEVnhxwR5ViL4zgIiIijJA/dxH5KbrlJoxE5pnOTv8A jjkHUe4/ODBBfz6iv7mwSB5fJZksKN2wX5IRGxWk4g1bWUqSIMcbifHCNXICCxeM ER4Kcp6UgU2VT45AxvLDwzRx2RwdYoI5MP+0nZqLlTqr2+qjDw9HnjObMemueyZO IpJcTgdE3Z8m5Rw+pkIsKXNT0R0qiaoqWkCVKC8Ob0HLzbjxwopBAC4GtnhT1qgE +sjEaDaa5RfWKgMmbCykeBvTfy5FivnbE+wVAc8kjwF5Gg1N9yWCbDEfwobf9Z3o wA7rttgiWGhZxM0Urwo+c/rp0woWtr0ZrFz1Br6dUyCHT2PzY38Wz/O6dLq10ssU dZ+/Zh7kj8g8den+kDizlna9cNVeQkbngKPLe68LKc8bXG9T9OYsD+vxT2wse+Lt Bs7GNkWZlq2jpdved34yKdNB/bdg22HaEtoRFu3150QiJpau+bjcGKjArvVspdGd FuXiBA4HMoK1+QO89lxBSwKAscIXfaH88zxBxfJ5UN0d/WcKaU82hnFYU39b4eGW QoxGDO130SfP8Ht5vyYOjB+PIQWd18QEJ1R44v3O0jeVOzpy4g6cJSs9UDbshp1k lMr6J31tFAX8r2QAwZgz =0KqW -----END PGP SIGNATURE----- --K8zN2sh9fO5jmbe4--