From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buxzz-0001XO-C5 for qemu-devel@nongnu.org; Fri, 14 Oct 2016 04:37:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buxzt-0006VV-8c for qemu-devel@nongnu.org; Fri, 14 Oct 2016 04:37:50 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40417 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buxzt-0006VL-3B for qemu-devel@nongnu.org; Fri, 14 Oct 2016 04:37:45 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9E8YM1W142160 for ; Fri, 14 Oct 2016 04:37:44 -0400 Received: from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148]) by mx0b-001b2d01.pphosted.com with ESMTP id 262uvcrejn-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 14 Oct 2016 04:37:44 -0400 Received: from localhost by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 14 Oct 2016 18:37:41 +1000 Date: Fri, 14 Oct 2016 14:07:32 +0530 From: Bharata B Rao Reply-To: bharata@linux.vnet.ibm.com References: <1476314039-9520-1-git-send-email-mdroth@linux.vnet.ibm.com> <1476314039-9520-8-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476314039-9520-8-git-send-email-mdroth@linux.vnet.ibm.com> Message-Id: <20161014083732.GC28693@in.ibm.com> Subject: Re: [Qemu-devel] [PATCH 07/11] spapr: add hotplug interrupt machine options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, nfont@linux.vnet.ibm.com, jallen@linux.vnet.ibm.com On Wed, Oct 12, 2016 at 06:13:55PM -0500, Michael Roth wrote: > This adds machine options of the form: > > -machine pseries,legacy-hotplug-events=true > -machine pseries,legacy-hotplug-events=false > > to denote whether or not we wish to force the use of "legacy" style > hotplug events, which are surfaced through EPOW interrupts instead of > a dedicated interrupt source, and lack certain features necessary, > mainly, for memory unplug support. > > If false, QEMU will default to "legacy" style unless the guest > advertises support for the newer events via > ibm,client-architecture-support hcall during early boot. > > For pseries-2.7 and earlier we default to true, for newer machine > types we default to false. > > Signed-off-by: Michael Roth > --- > hw/ppc/spapr.c | 31 +++++++++++++++++++++++++++++++ > include/hw/ppc/spapr.h | 1 + > include/hw/ppc/spapr_ovec.h | 1 + > 3 files changed, 33 insertions(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index f8cde92..d80a6fa 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -1816,6 +1816,11 @@ static void ppc_spapr_init(MachineState *machine) > > spapr_ovec_set(spapr->ov5, OV5_FORM1_AFFINITY); > > + /* use dedicated HP event source if guest supports it */ > + if (spapr->use_hotplug_event_source) { > + spapr_ovec_set(spapr->ov5, OV5_HP_EVT); The above comment can be confusing. Here you really mean that the machine type version supports OV5_HP_EVT right ? Because guest support for the same is determined during cas call later. Regards, Bharata.