From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buzBK-0008G4-F8 for qemu-devel@nongnu.org; Fri, 14 Oct 2016 05:53:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buzBE-0006OW-Iw for qemu-devel@nongnu.org; Fri, 14 Oct 2016 05:53:37 -0400 Date: Fri, 14 Oct 2016 10:53:30 +0100 From: Stefan Hajnoczi Message-ID: <20161014095330.GA20003@stefanha-x1.localdomain> References: <1476383370-30650-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yrj/dFKFPuw6o+aM" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] Fix build for less common build directories names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Stefan Weil , QEMU Developer , QEMU Trivial --yrj/dFKFPuw6o+aM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 13, 2016 at 07:36:07PM +0100, Peter Maydell wrote: > On 13 October 2016 at 19:29, Stefan Weil wrote: > > scripts/tracetool generates a C preprocessor macro from the name of the > > build directory. Any characters which are possible in a directory name > > but not allowed in a macro name must be substituted, otherwise builds > > will fail. > > > > Signed-off-by: Stefan Weil > > --- > > > > I had problems with a build directory of the form "host,variant". > > Is this fix needed for stable, too? >=20 > Why does it need to care about the build directory name at all? > Ideally builds should be entirely deterministically reproducible > whatever the path to the source or build directory names is... It's trying to construct the relative path from the source directory to a trace-events file (inside the source directory). This is used so that block/trace-event macros have BLOCK in their name while net/trace-events have NET, etc. It does not care about the build directory or source directory path per se. Therefore deterministic builds shouldn't be a problem if the code is working correctly ;). Stefan --yrj/dFKFPuw6o+aM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJYAKsaAAoJEJykq7OBq3PINHEIALA0yZ141O/ZSdCkZfTKfKkp yksh3q3LVsafDARUV3uHmA34IalpXiiHEh1i/UDae3d8NtvOJ0FjjgNSJz5uKUH1 YSTk7buDLBZny43YN+0HIp3RQwHF6N33mNUi5P0erwzQsrTJ3tiMypwFB5T8ratk OrF4Fr5RCFxfbr8K9ekIR5cl+TnDeo6g2bOj32XyuDhiBx04B6slFtXW4G/ud0a6 ZxW0ti+CJwOYm0kXaGGTpCbEq3zY/9xRtOowNUv4m4yi148LpoU1lvE1Ra8AXNzB 9xMsvKZC2W7D7O1ZLJiIpjejq2BHProIvHxOVp5NO0EoUd/mcyUWDVv843LiwpI= =w9cF -----END PGP SIGNATURE----- --yrj/dFKFPuw6o+aM--