qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Pradeep Kiruvale <pradeepkiruvale@gmail.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	"qemu-discuss@nongnu.org" <qemu-discuss@nongnu.org>
Subject: Re: [Qemu-devel] Virtio-net cli parameters
Date: Fri, 14 Oct 2016 14:26:26 +0100	[thread overview]
Message-ID: <20161014132626.GA3482@stefanha-x1.localdomain> (raw)
In-Reply-To: <CAJ2SuLmuwA421mWriqKn6M59-Gcr6R7ho5dvyiYTXNbZPTzA2g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2133 bytes --]

On Mon, Oct 10, 2016 at 03:00:20PM +0200, Pradeep Kiruvale wrote:
> On 10 October 2016 at 11:26, Pradeep Kiruvale <pradeepkiruvale@gmail.com>
> wrote:
> 
> > Hi Stefan,
> >
> > Thanks for the reply.
> >
> > On 30 September 2016 at 15:49, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> >
> >> On Thu, Sep 29, 2016 at 04:11:27PM +0200, Pradeep Kiruvale wrote:
> >> > Hi Stefan,
> >> >
> >> > On 28 September 2016 at 10:29, Stefan Hajnoczi <stefanha@gmail.com>
> >> wrote:
> >> >
> >> > > On Mon, Sep 26, 2016 at 05:41:55PM +0200, Pradeep Kiruvale wrote:
> >> > > > I want to add couple of new cli options for the virtio-net driver
> >> and use
> >> > > > them inside the
> >> > > > virtio-net driver to throttle the packets. I did go through the
> >> code and
> >> > > > did single stepping
> >> > > > using the gdb, but still could not find the place where the
> >> virtio-net
> >> > > > parameters are getting
> >> > > > parsed and populated into the virtio-net structures.
> >> > > > Could some one please guide/suggest where to look into, in qemu code
> >> > > base?
> >> > >
> >> > > Take a look at virtio_net_properties[] in hw/net/virtio-net.c.
> >> > >
> >> >
> >> > These variables/properties are static variables. What I am looking
> >> about is
> >> > how can I pass a cli option from qemu into virtio-net driver.
> >>
> >> When you say "virtio-net driver" I think you mean the virtio-net
> >> device emulation code in QEMU?
> >>
> > Yes, which the virtio-net driver uses to do the network I/O.
> >
> >>
> >> These *are* the properties that can be set from the QEMU command-line.
> >> For example:
> >>
> >>   -device virtio-net-pci,csum=off
> >>
> > This is the clue, I was looking for. I will see how to proceed from here
> > on.
> >
> But when I have a cli option like below, how can pass above options?
> -net nic,macaddr=52:54:00:37:4d:10,model=virtio

Please look at "Network Devices" in docs/qdev-device-use.txt for
information on modern -netdev/-device syntax.

The old -net syntax should be replaced with the more powerful
-netdev/-device syntax.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2016-10-14 13:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26 15:41 [Qemu-devel] Virtio-net cli parameters Pradeep Kiruvale
2016-09-28  8:29 ` Stefan Hajnoczi
2016-09-29  8:13   ` Pradeep Kiruvale
2016-09-29 14:11   ` Pradeep Kiruvale
2016-09-30 13:49     ` Stefan Hajnoczi
2016-10-10  9:26       ` Pradeep Kiruvale
2016-10-10 13:00         ` Pradeep Kiruvale
2016-10-14 13:26           ` Stefan Hajnoczi [this message]
2016-10-14 13:33             ` Pradeep Kiruvale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161014132626.GA3482@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=pradeepkiruvale@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-discuss@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).