From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bv4go-0005G8-LH for qemu-devel@nongnu.org; Fri, 14 Oct 2016 11:46:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bv4gm-0002bi-My for qemu-devel@nongnu.org; Fri, 14 Oct 2016 11:46:29 -0400 Date: Fri, 14 Oct 2016 17:46:20 +0200 From: Kevin Wolf Message-ID: <20161014154620.GH4473@noname.redhat.com> References: <1476399422-8028-1-git-send-email-jsnow@redhat.com> <1476399422-8028-7-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476399422-8028-7-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH 6/7] blockjobs: split interface into public/private, Part 1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-block@nongnu.org, xiecl.fnst@cn.fujitsu.com, wency@cn.fujitsu.com, jcody@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com Am 14.10.2016 um 00:57 hat John Snow geschrieben: > To make it a little more obvious which functions are intended to be > public interface and which are intended to be for use only by jobs > themselves, split the interface into "public" and "private" files. > > Convert blockjobs (e.g. block/backup) to using the private interface. > Leave blockdev and others on the public interface. > > There are remaining uses of private state by qemu-img, and several > cases in blockdev.c and block/io.c where we grab job->blk for the > purposes of acquiring an AIOContext. > > These will be corrected in future patches. > > Signed-off-by: John Snow Reviewed-by: Kevin Wolf