From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Xu Tian <xutian@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org, famz@redhat.com,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img: fix failed qemu-img command return zero exit code defeat
Date: Fri, 14 Oct 2016 17:49:46 +0200 [thread overview]
Message-ID: <20161014154946.GJ4473@noname.redhat.com> (raw)
In-Reply-To: <20161014153957.GE3482@stefanha-x1.localdomain>
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
Am 14.10.2016 um 17:39 hat Stefan Hajnoczi geschrieben:
> On Mon, Oct 10, 2016 at 11:07:09AM +0800, Xu Tian wrote:
> > If backing file can not open when do image rebase, flag 'ret' not
> > assign a non-zero value, then qemu-img process exit with code zero.
> > Assign value '-1' to flag 'ret' after report error message to fix
> > this defeat.
>
> I suggest rewording the commit description:
>
> img_rebase() returns 0 (success) when opening the backing file fails
> because 'ret' isn't set.
I already reworded it a bit when I applied the patch (it was sent twice
somehow and I replied to the other one):
If the backing file cannot be opened when doing qemu-img rebase, the
variable 'ret' was not assigned a non-zero value, and the qemu-img
process terminated with exit code zero. Fix this.
Kevin
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2016-10-14 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 3:07 [Qemu-devel] [Qemu-block][PATCH] qemu-img: fix failed qemu-img command return zero exit code defeat Xu Tian
2016-10-14 15:39 ` [Qemu-devel] [Qemu-block] [PATCH] " Stefan Hajnoczi
2016-10-14 15:49 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014154946.GJ4473@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xutian@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).