From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bv4nt-0002lS-GL for qemu-devel@nongnu.org; Fri, 14 Oct 2016 11:53:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bv4np-0006p8-BF for qemu-devel@nongnu.org; Fri, 14 Oct 2016 11:53:48 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:36644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bv4np-0006ou-4M for qemu-devel@nongnu.org; Fri, 14 Oct 2016 11:53:45 -0400 Received: by mail-wm0-x241.google.com with SMTP id 79so381552wmy.3 for ; Fri, 14 Oct 2016 08:53:44 -0700 (PDT) Date: Fri, 14 Oct 2016 16:53:42 +0100 From: Stefan Hajnoczi Message-ID: <20161014155342.GG3482@stefanha-x1.localdomain> References: <1476177724-28712-1-git-send-email-lprosek@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="df+09Je9rNq3P+GE" Content-Disposition: inline In-Reply-To: <1476177724-28712-1-git-send-email-lprosek@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] virtio: cosmetic tweaks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ladi Prosek Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com --df+09Je9rNq3P+GE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 11, 2016 at 11:22:02AM +0200, Ladi Prosek wrote: > Just a trivial couple of patches addressing minor style issues. >=20 > Enforcing the correct order of operations (pop, unpop, push, rewind) with= an assert, > which was another potential change discussed previously, would add a non-= trivial > amount of code and is not worth the effort in my opinion. A simple linked= -list of > VirtQueueElement would not be enough because these are not in the ownersh= ip of the > common virtio code. The effect of an out-of-order, yet valid, virtqueue_p= ush would > need to be encoded in the linked list even though the element has been de= allocated. > It's almost like maintaining a shadow available ring - doable but not jus= tified at > the moment. >=20 > Ladi Prosek (2): > virtio: rename virtqueue_discard to virtqueue_unpop > virtio: make virtqueue_alloc_element static >=20 >=20 Reviewed-by: Stefan Hajnoczi --df+09Je9rNq3P+GE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJYAP+GAAoJEJykq7OBq3PILuUH/0ryyo0Asfn070PVGATw7T/f A4IheC57kjcsd6uqM4RpCHXenT8zN8R97dW6cQOlaEonG8+FbTrh8lBDmxj68Hvt oeT77949VqxsrI5F3ttDJvqvntcLU/bmDEJDExWCVFu7ECtaJfjRf867HyeXhExu gD8g2Kc8i13y7+wv5sCv5YXreTXbFwp5DsvMlEP+w4p7y8/cEXN4SMgs6h8JXEsC Y6Rq8oLpoIscHTG/gLScFRaXwKl2SseP9HGOCvNJ3yXTXmYzrYCG5+dibbfKy/aG h6Qck7+7ObSWpVMyO1GSqXYC6VeJOZYB4NrkqYA3ucryAUXgYYTvuSx52nUH4+I= =lmR/ -----END PGP SIGNATURE----- --df+09Je9rNq3P+GE--