From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bv5cv-0004RW-3y for qemu-devel@nongnu.org; Fri, 14 Oct 2016 12:46:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bv5cq-0007qS-MV for qemu-devel@nongnu.org; Fri, 14 Oct 2016 12:46:31 -0400 Received: from 1.mo179.mail-out.ovh.net ([178.33.111.220]:47314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bv5cq-0007qF-Fy for qemu-devel@nongnu.org; Fri, 14 Oct 2016 12:46:28 -0400 Received: from player792.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo179.mail-out.ovh.net (Postfix) with ESMTP id 7E7F9FFA62F for ; Fri, 14 Oct 2016 18:46:27 +0200 (CEST) Date: Fri, 14 Oct 2016 18:46:22 +0200 From: Greg Kurz Message-ID: <20161014184622.1ed61a23@bahia> In-Reply-To: <1476435535-9408-3-git-send-email-lvivier@redhat.com> References: <1476435535-9408-1-git-send-email-lvivier@redhat.com> <1476435535-9408-3-git-send-email-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 2/6] tests: don't check if qtest_spapr_boot() returns NULL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: qemu-devel@nongnu.org, dgibson@redhat.com, thuth@redhat.com, qemu-ppc@nongnu.org On Fri, 14 Oct 2016 10:58:51 +0200 Laurent Vivier wrote: > qtest_spapr_boot()/qtest_pc_boot()/qtest_boot() call qtest_vboot() > and qtest_vboot() calls g_malloc(), > and g_malloc() never fails: > if memory allocation fails, the application is terminated. > And even if qtest_vboot() would be using g_try_malloc(), it would crash anyway: qs->qts = qtest_start(cmdline); qs->ops = ops; > Signed-off-by: Laurent Vivier > --- > tests/libqos/libqos.c | 1 + > tests/rtas-test.c | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/libqos/libqos.c b/tests/libqos/libqos.c > index 7abb482..65d6296 100644 > --- a/tests/libqos/libqos.c > +++ b/tests/libqos/libqos.c > @@ -10,6 +10,7 @@ > /** > * Launch QEMU with the given command line, > * and then set up interrupts and our guest malloc interface. > + * Never return NULL as the application is terminated if g_malloc() fails. True, but my point was that qtest_vboot() should never return NULL in any case: how could the caller (i.e. a test program) could possibly recover from such a failure ? > */ > QOSState *qtest_vboot(QOSOps *ops, const char *cmdline_fmt, va_list ap) > { > diff --git a/tests/rtas-test.c b/tests/rtas-test.c > index ba0867a..276c87e 100644 > --- a/tests/rtas-test.c > +++ b/tests/rtas-test.c > @@ -14,7 +14,6 @@ static void test_rtas_get_time_of_day(void) > time_t t1, t2; > > qs = qtest_spapr_boot("-machine pseries"); > - g_assert(qs != NULL); > > t1 = time(NULL); > ret = qrtas_get_time_of_day(qs->alloc, &tm, &ns);