From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59897)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bvidO-0007lX-PA
	for qemu-devel@nongnu.org; Sun, 16 Oct 2016 06:25:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bvidL-0004Z2-LK
	for qemu-devel@nongnu.org; Sun, 16 Oct 2016 06:25:38 -0400
Date: Sun, 16 Oct 2016 11:25:31 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20161016102531.GC11739@stefanha-x1.localdomain>
References: <1476380062-18001-1-git-send-email-pbonzini@redhat.com>
	<1476380062-18001-8-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="3siQDZowHQqNOShm"
Content-Disposition: inline
In-Reply-To: <1476380062-18001-8-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 07/18] block: introduce
 bdrv_poll_while and bdrv_wakeup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, famz@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org


--3siQDZowHQqNOShm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 13, 2016 at 07:34:11PM +0200, Paolo Bonzini wrote:
> @@ -485,9 +474,14 @@ void bdrv_inc_in_flight(BlockDriverState *bs)
>      atomic_inc(&bs->in_flight);
>  }
> =20
> +void bdrv_wakeup(BlockDriverState *bs)
> +{
> +}

Please write a doc comment explaining the semantics of this new API.

Since it's a nop here it may be better to introduce bdrv_wakeup() in
another patch.

--3siQDZowHQqNOShm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJYA1WaAAoJEJykq7OBq3PIQTAIAMcPe/wnGWvZ1UZUjbY1+nyh
xegJYSzrnxJBaq3E2HQHSiot33o58nZXiW8N0nAr63NVrIcDIMfMOSDT0t61j5PL
7uYN7BFAf0I3QOncUqk3QfD62nLnS9RXK15CzIBg8SyTh8rQPTWB/mESdq9dg4lx
496901GJ6Qx2gELwrdVmLK4E3+/YnDLBWeT/5RkZ8SmL8aHcA2SOCzG78q1yUGYQ
woCY0ihMTrjFslZ4EaDh1VGRftQDGhSLv2nH5vqoZd5wCAFxTfAX4vnpwP1Bh4gJ
iMJIxHDumeN0DDhTpoIW/FDrdimR138GzV0D8zJ/GrV6U40yWmKrMGo9AeiS4UM=
=17TS
-----END PGP SIGNATURE-----

--3siQDZowHQqNOShm--