qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Akanksha Srivastava <akanksha.dlf@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] usb: Change *_exitfn return type from int to void
Date: Sun, 16 Oct 2016 11:27:17 +0100	[thread overview]
Message-ID: <20161016102717.GD11739@stefanha-x1.localdomain> (raw)
In-Reply-To: <1476390091-6741-1-git-send-email-akanksha.dlf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

On Fri, Oct 14, 2016 at 01:51:31AM +0530, Akanksha Srivastava wrote:
> The *_exitfn functions cannot fail and should not be
> returning int.
> This also removes the passthru_exitfn since this callback
> does nothing as of now.
> This was suggested as a Bite-sized task for code cleanup.
> Signed-off-by: Akanksha Srivastava <akanksha.dlf@gmail.com>
> ---
>  hw/usb/ccid-card-emulated.c   |  3 +--
>  hw/usb/ccid-card-passthru.c   |  6 ------
>  hw/usb/ccid.h                 |  2 +-
>  hw/usb/dev-smartcard-reader.c | 11 +++++------
>  4 files changed, 7 insertions(+), 15 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2016-10-16 10:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13 20:21 [Qemu-devel] [PATCH v3] usb: Change *_exitfn return type from int to void Akanksha Srivastava
2016-10-16 10:27 ` Stefan Hajnoczi [this message]
2016-10-16 14:17 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161016102717.GD11739@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=akanksha.dlf@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).