From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvy1e-0001N5-TB for qemu-devel@nongnu.org; Sun, 16 Oct 2016 22:51:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvy1b-0003Ra-Q8 for qemu-devel@nongnu.org; Sun, 16 Oct 2016 22:51:42 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:54845 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bvy1b-0003RM-Kk for qemu-devel@nongnu.org; Sun, 16 Oct 2016 22:51:39 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9H2mfGv122753 for ; Sun, 16 Oct 2016 22:51:38 -0400 Received: from e23smtp07.au.ibm.com (e23smtp07.au.ibm.com [202.81.31.140]) by mx0b-001b2d01.pphosted.com with ESMTP id 263eapsv12-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Sun, 16 Oct 2016 22:51:38 -0400 Received: from localhost by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 17 Oct 2016 12:51:35 +1000 Date: Mon, 17 Oct 2016 08:21:26 +0530 From: Bharata B Rao Reply-To: bharata@linux.vnet.ibm.com References: <1476314039-9520-1-git-send-email-mdroth@linux.vnet.ibm.com> <1476314039-9520-8-git-send-email-mdroth@linux.vnet.ibm.com> <20161014083732.GC28693@in.ibm.com> <20161014180437.29726.76509@loki> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161014180437.29726.76509@loki> Message-Id: <20161017025126.GF28693@in.ibm.com> Subject: Re: [Qemu-devel] [PATCH 07/11] spapr: add hotplug interrupt machine options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, nfont@linux.vnet.ibm.com, jallen@linux.vnet.ibm.com On Fri, Oct 14, 2016 at 01:04:37PM -0500, Michael Roth wrote: > Quoting Bharata B Rao (2016-10-14 03:37:32) > > On Wed, Oct 12, 2016 at 06:13:55PM -0500, Michael Roth wrote: > > > This adds machine options of the form: > > > > > > -machine pseries,legacy-hotplug-events=true > > > -machine pseries,legacy-hotplug-events=false > > > > > > to denote whether or not we wish to force the use of "legacy" style > > > hotplug events, which are surfaced through EPOW interrupts instead of > > > a dedicated interrupt source, and lack certain features necessary, > > > mainly, for memory unplug support. > > > > > > If false, QEMU will default to "legacy" style unless the guest > > > advertises support for the newer events via > > > ibm,client-architecture-support hcall during early boot. > > > > > > For pseries-2.7 and earlier we default to true, for newer machine > > > types we default to false. > > > > > > Signed-off-by: Michael Roth > > > --- > > > hw/ppc/spapr.c | 31 +++++++++++++++++++++++++++++++ > > > include/hw/ppc/spapr.h | 1 + > > > include/hw/ppc/spapr_ovec.h | 1 + > > > 3 files changed, 33 insertions(+) > > > > > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > > index f8cde92..d80a6fa 100644 > > > --- a/hw/ppc/spapr.c > > > +++ b/hw/ppc/spapr.c > > > @@ -1816,6 +1816,11 @@ static void ppc_spapr_init(MachineState *machine) > > > > > > spapr_ovec_set(spapr->ov5, OV5_FORM1_AFFINITY); > > > > > > + /* use dedicated HP event source if guest supports it */ > > > + if (spapr->use_hotplug_event_source) { > > > + spapr_ovec_set(spapr->ov5, OV5_HP_EVT); > > > > The above comment can be confusing. Here you really mean that > > the machine type version supports OV5_HP_EVT right ? Because > > guest support for the same is determined during cas call later. > > What trying to get it across that support would only be enabled if the > guest indicates support for it later. What about something like: > > /* advertise support for dedicated HP event source to guests */ Sounds good. Thanks. > > > > Regards, > > Bharata.