From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bw3lb-00050r-MI for qemu-devel@nongnu.org; Mon, 17 Oct 2016 04:59:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bw3lb-0006Uh-1r for qemu-devel@nongnu.org; Mon, 17 Oct 2016 04:59:31 -0400 Date: Mon, 17 Oct 2016 16:59:17 +0800 From: Fam Zheng Message-ID: <20161017085917.GE28275@lemon> References: <1475272849-19990-1-git-send-email-jsnow@redhat.com> <1475272849-19990-11-git-send-email-jsnow@redhat.com> <1cf8db4a-8527-57ce-93be-d693064344bd@redhat.com> <20161010085713.GA6775@noname.redhat.com> <20161011093553.GA6334@noname.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161011093553.GA6334@noname.redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 10/11] blockjob: refactor backup_start as backup_job_create List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: John Snow , qemu-block@nongnu.org, vsementsov@virtuozzo.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, Paolo Bonzini On Tue, 10/11 11:35, Kevin Wolf wrote: > > >By the way, why did we allow to add a 'bitmap' option for DriveBackup > > >without adding it to BlockdevBackup at the same time? > > > > I don't remember. I'm not sure anyone ever audited it to convince > > themselves it was a useful or safe thing to do. I believe at the > > time I was pushing for bitmaps in DriveBackup, Fam was still > > authoring the BlockdevBackup interface. > > Hm, maybe that's why. I checked the commit dates of both (and there > BlockdevBackup was earlier), but I didn't check the development history. > > Should we add it now or is it a bad idea? Yes, we should add it. I'll send a separate patch. Thanks for catching that. Fam