From: Greg Kurz <groug@kaod.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PULL v2 19/20] trace: introduce a formal group name for trace events
Date: Mon, 17 Oct 2016 12:28:20 +0200 [thread overview]
Message-ID: <20161017122820.75f9b950@bahia> (raw)
In-Reply-To: <efecc30a-7e36-1eaa-0b9b-2c09d9dca702@redhat.com>
On Thu, 13 Oct 2016 15:58:55 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 12/10/2016 10:47, Stefan Hajnoczi wrote:
> > +def make_group_name(filename):
> > + dirname = os.path.realpath(os.path.dirname(filename))
> > + basedir = os.path.join(os.path.dirname(__file__), os.pardir)
> > + basedir = os.path.realpath(os.path.abspath(basedir))
> > + dirname = dirname[len(basedir) + 1:]
> > +
> > + if dirname == "":
> > + return "common"
> > + return re.sub(r"/|-", "_", dirname)
> >
>
> The group is based on the build directory, so it includes the relative
> path from srcdir to builddir. My build directory is weird ("+build")
> and breaks because of this. Since the group is not really used for
> anything yet, perhaps this patch could be reverted?
>
> Paolo
>
As pointed out in other mails, the real problem isn't even about ending
up with weird characters in the group name, but about including the
build directory itself...
--
Greg
next prev parent reply other threads:[~2016-10-17 10:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 8:47 [Qemu-devel] [PULL v2 00/20] Tracing patches Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 01/20] trace: move colo trace events to net/ sub-directory Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 02/20] trace: add trace event iterator APIs Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 03/20] trace: convert code to use event iterators Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 04/20] trace: remove some now unused functions Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 05/20] trace: remove global 'uint16 dstate[]' array Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 06/20] trace: remove duplicate control.h includes in generated-tracers.h Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 07/20] trace: break circular dependency in event-internal.h Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 08/20] trace: give each trace event a named TraceEvent struct Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 09/20] trace: remove the TraceEventID and TraceEventVCPUID enums Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 10/20] trace: emit name <-> ID mapping in simpletrace header Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 11/20] trace: don't abort qemu if ftrace can't be initialized Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 12/20] trace: provide mechanism for registering trace events Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 13/20] trace: dynamically allocate trace_dstate in CPUState Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 14/20] trace: dynamically allocate event IDs at runtime Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 15/20] trace: get rid of generated-events.h/generated-events.c Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 16/20] trace: rename _read_events to read_events Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 17/20] trace: push reading of events up a level to tracetool main Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 18/20] trace: pass trace-events to tracetool as a positional param Stefan Hajnoczi
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 19/20] trace: introduce a formal group name for trace events Stefan Hajnoczi
2016-10-13 13:58 ` Paolo Bonzini
2016-10-17 10:28 ` Greg Kurz [this message]
2016-10-12 8:47 ` [Qemu-devel] [PULL v2 20/20] trace: Add missing execution mode of guest events Stefan Hajnoczi
2016-10-12 11:13 ` [Qemu-devel] [PULL v2 00/20] Tracing patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017122820.75f9b950@bahia \
--to=groug@kaod.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).