From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwDOB-0007Ad-Q9 for qemu-devel@nongnu.org; Mon, 17 Oct 2016 15:16:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwDO7-00065O-Iz for qemu-devel@nongnu.org; Mon, 17 Oct 2016 15:15:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55516) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwDO7-00064v-DJ for qemu-devel@nongnu.org; Mon, 17 Oct 2016 15:15:55 -0400 Date: Mon, 17 Oct 2016 20:15:51 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20161017191550.GG12934@work-vm> References: <20161017185126.GD12934@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] qemu master tests/vmstate prints "Failed to load simple/primitive:b_1" etc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , armbru@redhat.com Cc: QEMU Developers * Peter Maydell (peter.maydell@linaro.org) wrote: > On 17 October 2016 at 19:51, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.maydell@linaro.org) wrote: > >> I've just noticed that qemu master running 'make check' prints > >> GTESTER tests/test-vmstate > >> Failed to load simple/primitive:b_1 > >> Failed to load simple/primitive:i64_2 > >> Failed to load simple/primitive:i32_1 > >> Failed to load simple/primitive:i32_1 > >> > >> but the test doesn't fail. > >> > >> Can we either (a) silence this output if it's spurious or (b) have > >> it cause the test to fail if it's real (and fix the cause of the > >> failure ;-)), please? > > > > The test (has always) tried loading truncated versions of the migration > > stream and made sure that it receives an error from vmstate_load_state. > > > > However I just added an error so we can see which field fails to load > > in a migration where we just used to get a 'migration has failed with -22' > > > > Is there a way to silence error_report's that's already in use in tests? > > We have some nasty hacks (like check for 'qtest_enabled()' before > calling error_report()) but we don't have anything in the > tree today that's a more coherent approach to the "test > deliberately provoked this error" problem. Errors go to either the current monitor (if it's non-qmp) or stderr; so could we create a dummy monitor to eat the errors and make it current around that part? Dave > > thanks > -- PMM -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK