From: Kevin Wolf <kwolf@redhat.com>
To: Pino Toscano <ptoscano@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, armbru@redhat.com,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qapi: fix memory leak in bdrv_image_info_specific_dump
Date: Tue, 18 Oct 2016 11:44:26 +0200 [thread overview]
Message-ID: <20161018094426.GC4706@noname.str.redhat.com> (raw)
In-Reply-To: <1476782280-3383-1-git-send-email-ptoscano@redhat.com>
Am 18.10.2016 um 11:18 hat Pino Toscano geschrieben:
> The 'obj' result of the visitor was not properly freed, like done in
> other places doing a similar job.
> ---
> block/qapi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/qapi.c b/block/qapi.c
> index 6f947e3..50d3090 100644
> --- a/block/qapi.c
> +++ b/block/qapi.c
> @@ -698,6 +698,7 @@ void bdrv_image_info_specific_dump(fprintf_function func_fprintf, void *f,
> assert(qobject_type(obj) == QTYPE_QDICT);
> data = qdict_get(qobject_to_qdict(obj), "data");
> dump_qobject(func_fprintf, f, 1, data);
> + qobject_decref(obj);
> visit_free(v);
> }
The change looks good, but without a Signed-off-by line I can't accept
the patch: http://wiki.qemu.org/Contribute/SubmitAPatch
Kevin
next prev parent reply other threads:[~2016-10-18 9:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 9:18 [Qemu-devel] [PATCH] qapi: fix memory leak in bdrv_image_info_specific_dump Pino Toscano
2016-10-18 9:44 ` Kevin Wolf [this message]
2016-10-18 10:36 ` Pino Toscano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018094426.GC4706@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=mreitz@redhat.com \
--cc=ptoscano@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).