From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwQwl-0003nO-9S for qemu-devel@nongnu.org; Tue, 18 Oct 2016 05:44:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwQwk-00045w-Fn for qemu-devel@nongnu.org; Tue, 18 Oct 2016 05:44:35 -0400 Date: Tue, 18 Oct 2016 11:44:26 +0200 From: Kevin Wolf Message-ID: <20161018094426.GC4706@noname.str.redhat.com> References: <1476782280-3383-1-git-send-email-ptoscano@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476782280-3383-1-git-send-email-ptoscano@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qapi: fix memory leak in bdrv_image_info_specific_dump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pino Toscano Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, armbru@redhat.com, mreitz@redhat.com Am 18.10.2016 um 11:18 hat Pino Toscano geschrieben: > The 'obj' result of the visitor was not properly freed, like done in > other places doing a similar job. > --- > block/qapi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/qapi.c b/block/qapi.c > index 6f947e3..50d3090 100644 > --- a/block/qapi.c > +++ b/block/qapi.c > @@ -698,6 +698,7 @@ void bdrv_image_info_specific_dump(fprintf_function func_fprintf, void *f, > assert(qobject_type(obj) == QTYPE_QDICT); > data = qdict_get(qobject_to_qdict(obj), "data"); > dump_qobject(func_fprintf, f, 1, data); > + qobject_decref(obj); > visit_free(v); > } The change looks good, but without a Signed-off-by line I can't accept the patch: http://wiki.qemu.org/Contribute/SubmitAPatch Kevin