qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"Huangweidong (C)" <weidong.huang@huawei.com>,
	Claudio Fontana <Claudio.Fontana@huawei.com>,
	"mst@redhat.com" <mst@redhat.com>,
	"xin.zeng@intel.com" <xin.zeng@intel.com>,
	"Hanweidong (Randy)" <hanweidong@huawei.com>,
	Luonengjun <luonengjun@huawei.com>,
	"agraf@suse.de" <agraf@suse.de>,
	"nmorey@kalray.eu" <nmorey@kalray.eu>,
	"mike.caraman@nxp.com" <mike.caraman@nxp.com>,
	"Zhoujian (jay, Euler)" <jianjay.zhou@huawei.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"Huangpeng (Peter)" <peter.huangpeng@huawei.com>,
	"vincent.jardin@6wind.com" <vincent.jardin@6wind.com>,
	"Wubin (H)" <wu.wubin@huawei.com>,
	"arei.gonglei@hotmail.com" <arei.gonglei@hotmail.com>
Subject: Re: [Qemu-devel] [virtio-dev] RE: [PATCH v7 09/12] virtio-crypto: add data queue processing handler
Date: Tue, 18 Oct 2016 11:08:46 +0100	[thread overview]
Message-ID: <20161018100846.GD19457@stefanha-x1.localdomain> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020B03F744B@SZXEMA503-MBS.china.huawei.com>

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

On Mon, Oct 17, 2016 at 06:29:42AM +0000, Gonglei (Arei) wrote:
> 
> > -----Original Message-----
> > From: Stefan Hajnoczi [mailto:stefanha@gmail.com]
> > Sent: Sunday, October 16, 2016 9:23 PM
> > Subject: Re: [Qemu-devel] [PATCH v7 09/12] virtio-crypto: add data queue
> > processing handler
> > 
> > On Thu, Oct 13, 2016 at 03:12:03PM +0800, Gonglei wrote:
> > > Introduces VirtIOCryptoReq structure to store
> > > crypto request so that we can support sync and async
> > > crypto operation in the future.
> > 
> > What do you mean by "sync and async" operations?
> > 
> Synchronous and asynchronous.

I understand the words but:

1. The virtio interface is always asynchronous because request
   submission and completion on the virtqueue are separate steps (kick
   and irq).  The guest always thinks the operation is asynchronous.

2. If you implement operations synchronously inside QEMU then monitor
   and other QEMU threads could be blocked.  Also you will not be able
   to take advantage of parallel requests to the hardware crypto
   accelerator!

So I think it makes sense to implement everything asynchronously.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2016-10-18 10:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13  7:11 [Qemu-devel] [PATCH v7 00/12] virtio-crypto: introduce framework and device emulation Gonglei
2016-10-13  7:11 ` [Qemu-devel] [PATCH v7 01/12] cryptodev: introduce cryptodev backend interface Gonglei
2016-10-13  7:11 ` [Qemu-devel] [PATCH v7 02/12] cryptodev: add symmetric algorithm operation stuff Gonglei
2016-10-13  7:11 ` [Qemu-devel] [PATCH v7 03/12] virtio-crypto: introduce virtio_crypto.h Gonglei
2016-10-13  7:11 ` [Qemu-devel] [PATCH v7 04/12] cryptodev: introduce a new cryptodev backend Gonglei
2016-10-13  7:11 ` [Qemu-devel] [PATCH v7 05/12] virtio-crypto: add virtio crypto device emulation Gonglei
2016-10-13  7:12 ` [Qemu-devel] [PATCH v7 06/12] virtio-crypto-pci: add virtio crypto pci support Gonglei
2016-10-13  7:12 ` [Qemu-devel] [PATCH v7 07/12] virtio-crypto: set capacity of algorithms supported Gonglei
2016-10-13  7:12 ` [Qemu-devel] [PATCH v7 08/12] virtio-crypto: add control queue handler Gonglei
2016-10-16 13:02   ` Stefan Hajnoczi
2016-10-17  5:58     ` Gonglei (Arei)
2016-10-13  7:12 ` [Qemu-devel] [PATCH v7 09/12] virtio-crypto: add data queue processing handler Gonglei
2016-10-16 13:22   ` Stefan Hajnoczi
2016-10-17  6:29     ` Gonglei (Arei)
2016-10-18 10:08       ` Stefan Hajnoczi [this message]
2016-10-19  3:43         ` [Qemu-devel] [virtio-dev] " Gonglei (Arei)
2016-10-13  7:12 ` [Qemu-devel] [PATCH v7 10/12] cryptodev: introduce an unified wrapper for crypto operation Gonglei
2016-10-16 13:26   ` Stefan Hajnoczi
2016-10-17  6:32     ` Gonglei (Arei)
2016-10-13  7:12 ` [Qemu-devel] [PATCH v7 11/12] virtio-crypto: add myself as virtio-crypto and cryptodev backends maintainer Gonglei
2016-10-13  7:12 ` [Qemu-devel] [PATCH v7 12/12] virtio-crypto: perfect algorithms chainning support Gonglei
2016-10-16 13:30   ` Stefan Hajnoczi
2016-10-17  6:33     ` Gonglei (Arei)
2016-10-13  8:11 ` [Qemu-devel] [PATCH v7 00/12] virtio-crypto: introduce framework and device emulation no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161018100846.GD19457@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=Claudio.Fontana@huawei.com \
    --cc=agraf@suse.de \
    --cc=arei.gonglei@hotmail.com \
    --cc=arei.gonglei@huawei.com \
    --cc=hanweidong@huawei.com \
    --cc=jianjay.zhou@huawei.com \
    --cc=luonengjun@huawei.com \
    --cc=mike.caraman@nxp.com \
    --cc=mst@redhat.com \
    --cc=nmorey@kalray.eu \
    --cc=pbonzini@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=vincent.jardin@6wind.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=weidong.huang@huawei.com \
    --cc=wu.wubin@huawei.com \
    --cc=xin.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).