From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwS5a-0001Se-NO for qemu-devel@nongnu.org; Tue, 18 Oct 2016 06:57:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwS5X-0006ju-Li for qemu-devel@nongnu.org; Tue, 18 Oct 2016 06:57:46 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47976) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwS5X-0006jW-CT for qemu-devel@nongnu.org; Tue, 18 Oct 2016 06:57:43 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9IAsVCF141502 for ; Tue, 18 Oct 2016 06:57:42 -0400 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0a-001b2d01.pphosted.com with ESMTP id 265f3gsk7w-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 18 Oct 2016 06:57:42 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 18 Oct 2016 11:57:40 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7A1031B08061 for ; Tue, 18 Oct 2016 11:59:39 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9IAva0924313964 for ; Tue, 18 Oct 2016 10:57:36 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9IAvZcE009801 for ; Tue, 18 Oct 2016 06:57:36 -0400 From: Halil Pasic Date: Tue, 18 Oct 2016 12:57:20 +0200 Message-Id: <20161018105724.26520-1-pasic@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 0/4] remove unused VMSTateField.start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Amit Shah , Guenther Hutzl , "Dr. David Alan Gilbert" , Halil Pasic The member VMStateField.start was solely used to implement the partial data migration for VBUFFER data (basically provide migration for a sub-buffer). However the implementation of this feature is broken, but this goes unnoticed since the feature is not used at all. So what the series does is first add some tests for VBUFFER, then add a test which proves that the VMS_ALLOC and used together with .start != 0 is broken. Then we immediately revert this last patch since we are going to drop it instead of fixing it. Lastly simplify things by dropping VMStateField.start altogether. An additional benefit is that .start can be re introduced to be used for linked structures as proposed by Jianjun in "[QEMU PATCH v6 2/2] migration: migrate QTAILQ". Guenther Hutzl (1): tests/test-vmstate.c: Add vBuffer test Halil Pasic (3): tests/test-vmstate.c: prove VMStateField.start broken Revert "tests/test-vmstate.c: prove VMStateField.start broken" migration: drop unused VMStateField.start hw/char/exynos4210_uart.c | 2 +- hw/display/g364fb.c | 2 +- hw/dma/pl330.c | 8 +-- hw/intc/exynos4210_gic.c | 2 +- hw/ipmi/isa_ipmi_bt.c | 4 +- hw/ipmi/isa_ipmi_kcs.c | 4 +- hw/net/vmxnet3.c | 2 +- hw/nvram/mac_nvram.c | 2 +- hw/nvram/spapr_nvram.c | 2 +- hw/sd/sdhci.c | 2 +- hw/timer/m48t59.c | 2 +- include/migration/vmstate.h | 20 +++----- migration/savevm.c | 2 +- migration/vmstate.c | 4 +- target-s390x/machine.c | 2 +- tests/test-vmstate.c | 115 +++++++++++++++++++++++++++++++++++++++++++- util/fifo8.c | 2 +- 17 files changed, 141 insertions(+), 36 deletions(-) -- 2.8.4