From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwS5Y-0001Qs-PS for qemu-devel@nongnu.org; Tue, 18 Oct 2016 06:57:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwS5V-0006ij-Le for qemu-devel@nongnu.org; Tue, 18 Oct 2016 06:57:44 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58745 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwS5V-0006iZ-Gs for qemu-devel@nongnu.org; Tue, 18 Oct 2016 06:57:41 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9IAt1CA010063 for ; Tue, 18 Oct 2016 06:57:40 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 265j6urvfa-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 18 Oct 2016 06:57:40 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 18 Oct 2016 11:57:39 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9DBA5219005F for ; Tue, 18 Oct 2016 11:56:53 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9IAva5Q29294688 for ; Tue, 18 Oct 2016 10:57:36 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9IAvaeY009811 for ; Tue, 18 Oct 2016 06:57:36 -0400 From: Halil Pasic Date: Tue, 18 Oct 2016 12:57:21 +0200 In-Reply-To: <20161018105724.26520-1-pasic@linux.vnet.ibm.com> References: <20161018105724.26520-1-pasic@linux.vnet.ibm.com> Message-Id: <20161018105724.26520-2-pasic@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 1/4] tests/test-vmstate.c: Add vBuffer test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Amit Shah , Guenther Hutzl , "Dr. David Alan Gilbert" , Halil Pasic From: Guenther Hutzl The unit test test-vmstate.c is missing tests for some of the complex vmstate macros. This patch adds a new test for VMSTATE_VBUFFER and VMSTATE_VBUFFER_ALLOC_UINT32. The added test does not cover start != 0 because it's broken and unused so our intention is to remove start altogether. Signed-off-by: Guenther Hutzl Signed-off-by: Halil Pasic --- A proof for the brokenness of start is provided in a separate patch so it can be easily reverted or not picked (thus we separate what is intended to stay, and what is intended to go away). --- tests/test-vmstate.c | 114 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 114 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index d8da26f..9a57aa0 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -475,6 +475,119 @@ static void test_load_skip(void) qemu_fclose(loading); } +/* vBuffer tests */ +#define BUF_SIZE 10 + +typedef struct TestVBuffer { + uint8_t u8_1; + int32_t buffer_size; + uint8_t *vBuffer_1; + uint32_t buffer_alloc_size; + uint8_t *vBuffer_alloc_1; + uint8_t u8_2; +} TestVBuffer; + +/* buffers padded with 0xFE at the end to easier detect overflow */ +uint8_t buf1[BUF_SIZE + 1] = { 1, 2, 3, 4, 5, 6, 7, 8, 9, 0, 0xfe}; +uint8_t buf2[BUF_SIZE + 1] = { 1, 2, 3, 4, 5, 6, 7, 8, 9, 0, 0xfe}; + +TestVBuffer obj_vbuffer = { + .u8_1 = 100, + .buffer_size = BUF_SIZE, + .vBuffer_1 = buf1, + .buffer_alloc_size = BUF_SIZE, + .vBuffer_alloc_1 = buf2, + .u8_2 = 200, +}; + +static const VMStateDescription vmstate_vbuffer = { + .name = "complex/vbuffer", + .version_id = 1, + .minimum_version_id = 1, + .fields = (VMStateField[]) { + VMSTATE_UINT8(u8_1, TestVBuffer), + VMSTATE_VBUFFER(vBuffer_1, TestVBuffer, 1, NULL, 0, + buffer_size), + VMSTATE_VBUFFER_ALLOC_UINT32(vBuffer_alloc_1, TestVBuffer, 1, NULL, 0, + buffer_alloc_size), + VMSTATE_UINT8(u8_2, TestVBuffer), + VMSTATE_END_OF_LIST() + } +}; + +uint8_t wire_vbuffer[] = { + /* u8_1 */ 0x64, + /* vBuffer_1 */ 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, + 0x00, + /* vBuffer_alloc_1 */ 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, + 0x00, + /* u8_2 */ 0xc8, + QEMU_VM_EOF, /* just to ensure we won't get EOF reported prematurely */ +}; + +static void obj_vbuffer_copy(void *target, void *source) +{ + /* this proc copies all struct TestVBuffer entries from source to target + except the vBuffer pointers which should already point to the correct + locations. The buffer contents are also copied */ + TestVBuffer *s = (TestVBuffer *)source; + TestVBuffer *t = (TestVBuffer *)target; + + t->u8_1 = s->u8_1; + t->u8_2 = s->u8_2; + t->buffer_size = s->buffer_size; + t->buffer_alloc_size = s->buffer_alloc_size; + if (t->vBuffer_1 && s->vBuffer_1) { + memcpy(t->vBuffer_1, s->vBuffer_1, BUF_SIZE); + } + if (t->vBuffer_alloc_1 && s->vBuffer_alloc_1) { + memcpy(t->vBuffer_alloc_1, s->vBuffer_alloc_1, BUF_SIZE); + } +} + +static void test_complex_vbuffer(void) +{ + uint8_t buffer[BUF_SIZE]; + uint8_t buffer_clone[BUF_SIZE]; + TestVBuffer obj = { + .u8_1 = 0, + .buffer_size = BUF_SIZE, + .vBuffer_1 = buffer, + .buffer_alloc_size = BUF_SIZE, + .vBuffer_alloc_1 = NULL, + .u8_2 = 0, + }; + TestVBuffer obj_clone = { + .u8_1 = 0, + .buffer_size = BUF_SIZE, + .vBuffer_1 = buffer_clone, + .buffer_alloc_size = BUF_SIZE, + .vBuffer_alloc_1 = NULL, + .u8_2 = 0, + }; + + memset(buffer, 0, BUF_SIZE); + memset(buffer_clone, 0, BUF_SIZE); + + save_vmstate(&vmstate_vbuffer, &obj_vbuffer); + + compare_vmstate(wire_vbuffer, sizeof(wire_vbuffer)); + + SUCCESS(load_vmstate(&vmstate_vbuffer, &obj, &obj_clone, + obj_vbuffer_copy, 1, wire_vbuffer, + sizeof(wire_vbuffer))); + +#define FIELD_EQUAL(name) g_assert_cmpint(obj.name, ==, obj_vbuffer.name) +#define BUFFER_EQUAL(name) SUCCESS(memcmp(obj.name, obj_vbuffer.name, BUF_SIZE)) + + FIELD_EQUAL(u8_1); + BUFFER_EQUAL(vBuffer_1); + BUFFER_EQUAL(vBuffer_alloc_1); + FIELD_EQUAL(u8_2); +} +#undef FIELD_EQUAL +#undef BUFFER_EQUAL + int main(int argc, char **argv) { temp_fd = mkstemp(temp_file); @@ -489,6 +602,7 @@ int main(int argc, char **argv) g_test_add_func("/vmstate/field_exists/load/skip", test_load_skip); g_test_add_func("/vmstate/field_exists/save/noskip", test_save_noskip); g_test_add_func("/vmstate/field_exists/save/skip", test_save_skip); + g_test_add_func("/vmstate/complex/vbuffer", test_complex_vbuffer); g_test_run(); close(temp_fd); -- 2.8.4