From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwUXW-0000wb-9r for qemu-devel@nongnu.org; Tue, 18 Oct 2016 09:34:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwUXV-0005lR-IR for qemu-devel@nongnu.org; Tue, 18 Oct 2016 09:34:46 -0400 Date: Tue, 18 Oct 2016 21:34:35 +0800 From: Fam Zheng Message-ID: <20161018133435.GD14000@lemon> References: <20161017201530.502017.26289@ex-std-node742.prod.rhcloud.com> <6011d25f-9302-b3dc-36f1-567daf23b62d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6011d25f-9302-b3dc-36f1-567daf23b62d@redhat.com> Subject: Re: [Qemu-devel] [RFC v5 0/8] KVM PCI/MSI passthrough with mach-virt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Auger Eric Cc: qemu-devel@nongnu.org, eric.auger.pro@gmail.com, peter.maydell@linaro.org, qemu-arm@nongnu.org, alex.williamson@redhat.com, pranav.sawargaonkar@gmail.com, diana.craciun@freescale.com, Bharat.Bhushan@freescale.com, drjones@redhat.com, christoffer.dall@linaro.org, fkan@apm.com On Mon, 10/17 22:56, Auger Eric wrote: > > make[1]: *** No rule to make target `../hw/core/platform-bus-stub.o', needed by `qemu-system-x86_64'. Stop. > I can't figure out why this rule is missing? > > I compiled on x86 and aarch64 with > ./configure --target-list="x86_64-softmmu" --enable-werror and it looks > OK. What do I miss here? I think the reason it doesn't work is this: common-obj-y objects are built as prerequisite of $(SUBDIR_RULES) which is defined in Makefile, from which the unnest of common-obj-y doesn't include this stub object, because Makefile doesn't read default-config; later make enters Makefile.target, this time common-obj-y _includes_ platform-bus-stub.o, but the object rule doesn't work there. I think the easiest solution is still move the stub function to stubs/, or otherwise you need to fix Makefile or rules.mak for this to work. Fam