qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] invtsc + migration + TSC scaling
Date: Tue, 18 Oct 2016 15:48:46 +0200	[thread overview]
Message-ID: <20161018134846.GB3492@potion> (raw)
In-Reply-To: <20161017235846.GA22657@amt.cnet>

2016-10-17 21:58-0200, Marcelo Tosatti:
> On Mon, Oct 17, 2016 at 07:11:01PM -0200, Eduardo Habkost wrote:
>> On Mon, Oct 17, 2016 at 06:24:38PM +0200, Paolo Bonzini wrote:
>> > On 17/10/2016 16:50, Radim Krčmář wrote:
>> > > 2016-10-17 07:47-0200, Marcelo Tosatti:
>> [...]
>> > >> since Linux guests use kvmclock and Windows guests use Hyper-V
>> > >> enlightenment, it should be fine to disable 2).
>> > 
>> > ... and 1 too.
>> > 
>> > We should also blacklist the TSC deadline timer when invtsc is not
>> > available.
> 
> Actually, a nicer fix would be to check the different 
> frequencies and scale the deadline relative to the difference. 

I think that KVM can already be configured to do that.

Paolo, we hit that TSC deadline bug bacause QEMU doesn't set the TSC
frequency if it would result in software scaling (which needs to update
guest TSC and kvmclock on every entry)?

Thanks.

(I just noticed a minor bug: KVM doesn't use hardware scaling when the
 TSC frequency delta is small.)

> This would take care of both patched and non-patched guests.
> 
> On a related note, what was the goal of Radim's paravirtual deadline
> TSC timer?

It's be paravirtual kvmclock timer -- just giving the deadline in other
another time frame.  It won't confuse OS that expect the deadline timer
to behave like it should. :)

  parent reply	other threads:[~2016-10-18 13:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-14 21:20 [Qemu-devel] invtsc + migration + TSC scaling Eduardo Habkost
2016-10-17  9:47 ` Marcelo Tosatti
2016-10-17 14:50   ` Radim Krčmář
2016-10-17 16:24     ` Paolo Bonzini
2016-10-17 21:11       ` Eduardo Habkost
2016-10-17 23:58         ` Marcelo Tosatti
2016-10-18 13:41           ` Paolo Bonzini
2016-10-18 17:09             ` Marcelo Tosatti
2016-10-18 20:52               ` Radim Krčmář
2016-10-18 21:05                 ` Eduardo Habkost
2016-10-19 13:27                   ` Radim Krčmář
2016-10-19 13:55                     ` Eduardo Habkost
2016-10-19 15:42                       ` Radim Krčmář
2016-10-19 17:42                         ` Eduardo Habkost
2016-10-18 13:48           ` Radim Krčmář [this message]
2016-10-18 13:36       ` Radim Krčmář
2016-10-18 13:38         ` Radim Krčmář
2016-10-17 17:20     ` Marcelo Tosatti
2016-10-18 13:27       ` Radim Krčmář
2016-10-18  9:04     ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161018134846.GB3492@potion \
    --to=rkrcmar@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).