From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Halil Pasic <pasic@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, Amit Shah <amit.shah@redhat.com>,
Guenther Hutzl <hutzl@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] tests/test-vmstate.c: prove VMStateField.start broken
Date: Tue, 18 Oct 2016 14:54:27 +0100 [thread overview]
Message-ID: <20161018135426.GJ2190@work-vm> (raw)
In-Reply-To: <bcf887ed-a393-85db-c51e-e912bbe98b6d@linux.vnet.ibm.com>
* Halil Pasic (pasic@linux.vnet.ibm.com) wrote:
>
>
> On 10/18/2016 03:27 PM, Dr. David Alan Gilbert wrote:
> > * Halil Pasic (pasic@linux.vnet.ibm.com) wrote:
> >> > The handling of VMStateField.start is currently quite broken if
> >> > VMS_ALLOC is present (that is for VMSTATE_VBUFFER_ALLOC_UINT32) but
> >> > fortunately also quite underutilized -- nobody is using .start != 0.
> >> >
> >> > Let's prove with this patch that it's really broken (as a first
> >> > step towards fixing things up).
> > You can't play this trick - patch series have to work and pass
> > tests after each test, otherwise it messes up people in the future
> > trying to do a git bisect.
> >
> > Dave
> >
>
> I think I understand the motivation. Does that mean
> you are not supposed to expose a bug via a test? I might
> be able to demonstrate that something is wrong but unable
> to fix the problem myself (time constraints).
>
> How was I supposed to do this?
You might add a test but leave it commented out, or just post
the test but not for merging so that it only gets merged
after someone fixes the bug.
Dave
>
> Cheers,
> Halil
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2016-10-18 13:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 10:57 [Qemu-devel] [PATCH 0/4] remove unused VMSTateField.start Halil Pasic
2016-10-18 10:57 ` [Qemu-devel] [PATCH 1/4] tests/test-vmstate.c: Add vBuffer test Halil Pasic
2016-10-20 11:52 ` Dr. David Alan Gilbert
2016-10-18 10:57 ` [Qemu-devel] [PATCH 2/4] tests/test-vmstate.c: prove VMStateField.start broken Halil Pasic
2016-10-18 13:27 ` Dr. David Alan Gilbert
2016-10-18 13:43 ` Halil Pasic
2016-10-18 13:54 ` Dr. David Alan Gilbert [this message]
2016-10-18 15:33 ` Halil Pasic
2016-10-18 18:32 ` Dr. David Alan Gilbert
2016-10-19 11:04 ` Halil Pasic
2016-10-20 12:00 ` Dr. David Alan Gilbert
2016-10-20 13:05 ` Halil Pasic
2016-10-18 10:57 ` [Qemu-devel] [PATCH 3/4] Revert "tests/test-vmstate.c: prove VMStateField.start broken" Halil Pasic
2016-10-18 10:57 ` [Qemu-devel] [PATCH 4/4] migration: drop unused VMStateField.start Halil Pasic
2016-10-20 12:00 ` Dr. David Alan Gilbert
2016-10-18 11:24 ` [Qemu-devel] [PATCH 0/4] remove unused VMSTateField.start no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018135426.GJ2190@work-vm \
--to=dgilbert@redhat.com \
--cc=amit.shah@redhat.com \
--cc=hutzl@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).