qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pranith Kumar <bobby.prani@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>,
	Richard Henderson <rth@twiddle.net>,
	"open list:Overall" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH 2/2] translate-all: Use proper type
Date: Tue, 18 Oct 2016 10:56:20 -0400	[thread overview]
Message-ID: <20161018145620.20658-2-bobby.prani@gmail.com> (raw)
In-Reply-To: <20161018145620.20658-1-bobby.prani@gmail.com>

gcc does not warn about the wrong type since it is a void pointer
which can be cast to any type.

Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
 translate-all.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/translate-all.c b/translate-all.c
index 8ca393c..c77470a 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -412,7 +412,7 @@ static PageDesc *page_find_alloc(tb_page_addr_t index, int alloc)
 
     /* Level 2..N-1.  */
     for (i = V_L1_SHIFT / V_L2_BITS - 1; i > 0; i--) {
-        void **p = atomic_rcu_read(lp);
+        void *p = atomic_rcu_read(lp);
 
         if (p == NULL) {
             if (!alloc) {
-- 
2.10.1

  reply	other threads:[~2016-10-18 14:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18 14:56 [Qemu-devel] [PATCH 1/2] docs/rcu: Distinguish rcu_dereference and atomic_rcu_read Pranith Kumar
2016-10-18 14:56 ` Pranith Kumar [this message]
2016-10-18 18:34   ` [Qemu-devel] [PATCH 2/2] translate-all: Use proper type Emilio G. Cota
2016-10-18 18:43     ` Eric Blake
2016-10-18 19:14       ` Pranith Kumar
2016-10-18 21:55   ` Paolo Bonzini
2016-10-18 21:50 ` [Qemu-devel] [PATCH 1/2] docs/rcu: Distinguish rcu_dereference and atomic_rcu_read Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161018145620.20658-2-bobby.prani@gmail.com \
    --to=bobby.prani@gmail.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).