From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwUyR-0000kB-Gl for qemu-devel@nongnu.org; Tue, 18 Oct 2016 10:02:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwUyM-0000ip-Ku for qemu-devel@nongnu.org; Tue, 18 Oct 2016 10:02:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59714) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwUyM-0000iR-FE for qemu-devel@nongnu.org; Tue, 18 Oct 2016 10:02:30 -0400 Date: Tue, 18 Oct 2016 16:02:26 +0200 From: Igor Mammedov Message-ID: <20161018160226.4c78a90f@nial.brq.redhat.com> In-Reply-To: <20161018134711.GT3275@thinpad.lan.raisama.net> References: <1476352367-69400-1-git-send-email-imammedo@redhat.com> <1476352367-69400-4-git-send-email-imammedo@redhat.com> <20161018133455.GR3275@thinpad.lan.raisama.net> <20161018154605.6f7ce579@nial.brq.redhat.com> <20161018134711.GT3275@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 03/13] acpi: cphp: support x2APIC entry in cpu._MAT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, kraxel@redhat.com, liuxiaojian6@huawei.com, mst@redhat.com, rkrcmar@redhat.com, peterx@redhat.com, kevin@koconnor.net, pbonzini@redhat.com, lersek@redhat.com, chao.gao@intel.com On Tue, 18 Oct 2016 11:47:11 -0200 Eduardo Habkost wrote: > On Tue, Oct 18, 2016 at 03:46:05PM +0200, Igor Mammedov wrote: > > On Tue, 18 Oct 2016 11:34:55 -0200 > > Eduardo Habkost wrote: > > > > > On Thu, Oct 13, 2016 at 11:52:37AM +0200, Igor Mammedov wrote: > > > > Signed-off-by: Igor Mammedov > > > > --- > > > > hw/acpi/cpu.c | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/hw/acpi/cpu.c b/hw/acpi/cpu.c > > > > index 902f5c9..5ac89fe 100644 > > > > --- a/hw/acpi/cpu.c > > > > +++ b/hw/acpi/cpu.c > > > > @@ -531,6 +531,11 @@ void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures opts, > > > > apic->flags = cpu_to_le32(1); > > > > break; > > > > } > > > > + case ACPI_APIC_LOCAL_X2APIC: { > > > > + AcpiMadtProcessorX2Apic *apic = (void *)madt_buf->data; > > > > + apic->flags = cpu_to_le32(1); > > > > + break; > > > > + } > > > > > > Shouldn't this patch be applied before 01/13 to avoid triggering > > > the assert() below? > > There is no AcpiMadtProcessorX2Apic before 1/13, > > > > how about squashing this patch into 1/13, that should be cleaner. > > It would work, too. I assume you will squash it on v4 of 01/13. > yep