From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwY18-0006pL-Df for qemu-devel@nongnu.org; Tue, 18 Oct 2016 13:17:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwY15-0001DY-J4 for qemu-devel@nongnu.org; Tue, 18 Oct 2016 13:17:34 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:56613) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwY15-0001Cu-BI for qemu-devel@nongnu.org; Tue, 18 Oct 2016 13:17:31 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9IHEkqp089233 for ; Tue, 18 Oct 2016 13:17:29 -0400 Received: from e06smtp09.uk.ibm.com (e06smtp09.uk.ibm.com [195.75.94.105]) by mx0a-001b2d01.pphosted.com with ESMTP id 265p26p0x3-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 18 Oct 2016 13:17:29 -0400 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 18 Oct 2016 18:17:27 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7566D219004D for ; Tue, 18 Oct 2016 18:16:41 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9IHHObE27787312 for ; Tue, 18 Oct 2016 17:17:24 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9IHHOW5016958 for ; Tue, 18 Oct 2016 13:17:24 -0400 Date: Tue, 18 Oct 2016 19:17:23 +0200 From: Cornelia Huck In-Reply-To: <1476100421-28772-2-git-send-email-pbonzini@redhat.com> References: <1476100421-28772-1-git-send-email-pbonzini@redhat.com> <1476100421-28772-2-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20161018191723.71ca31c9.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 01/13] virtio: disable ioeventfd as early as possible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com, borntraeger@de.ibm.com, famz@redhat.com, mst@redhat.com On Mon, 10 Oct 2016 13:53:29 +0200 Paolo Bonzini wrote: > Avoid "tricking" virtio-blk-dataplane into thinking that ioeventfd will be > available when it is not. This bug has always been there, but it will break > TCG+ioeventfd=on once the dataplane code will be always used when ioeventfd=on. > > Signed-off-by: Paolo Bonzini > --- > hw/s390x/virtio-ccw.c | 8 ++++---- > hw/virtio/virtio-pci.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) I had simply copied the pci logic (as in other places :), but this makes sense. Reviewed-by: Cornelia Huck