From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwY6Q-0001re-Rm for qemu-devel@nongnu.org; Tue, 18 Oct 2016 13:23:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwY6O-0002Oe-64 for qemu-devel@nongnu.org; Tue, 18 Oct 2016 13:23:02 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58347) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwY6N-0002OS-TE for qemu-devel@nongnu.org; Tue, 18 Oct 2016 13:23:00 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9IHJIKt104971 for ; Tue, 18 Oct 2016 13:22:58 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 265hjcy5mk-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 18 Oct 2016 13:22:58 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 18 Oct 2016 18:22:56 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id B1DE717D8024 for ; Tue, 18 Oct 2016 18:25:05 +0100 (BST) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9IHMsR123920732 for ; Tue, 18 Oct 2016 17:22:54 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9IHMrNP009591 for ; Tue, 18 Oct 2016 11:22:54 -0600 Date: Tue, 18 Oct 2016 19:22:51 +0200 From: Cornelia Huck In-Reply-To: <1476100421-28772-4-git-send-email-pbonzini@redhat.com> References: <1476100421-28772-1-git-send-email-pbonzini@redhat.com> <1476100421-28772-4-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20161018192251.79574bda.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 03/13] virtio: move ioeventfd_started flag to VirtioBusState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com, borntraeger@de.ibm.com, famz@redhat.com, mst@redhat.com On Mon, 10 Oct 2016 13:53:31 +0200 Paolo Bonzini wrote: > This simplifies the code and removes the ioeventfd_started > and ioeventfd_set_started callback. The only difference is > in how virtio-ccw handles an error---it doesn't disable > ioeventfd forever anymore. It was the only backend to do > so, and if desired this behavior should be implemented in > virtio-bus.c. I guess this depends on whether we consider failures to be generally transient or generally permanent. I decided to disable ioeventfd on failure as I could not think of a transient failure; but in the end, it does not really matter much, so I'm fine with this change. > > Instead of ioeventfd_started, the ioeventfd_assign callback now > determines whether the virtio bus supports host notifiers. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini > --- > hw/block/dataplane/virtio-blk.c | 2 +- > hw/s390x/virtio-ccw.c | 21 --------------------- > hw/s390x/virtio-ccw.h | 1 - > hw/scsi/virtio-scsi-dataplane.c | 2 +- > hw/virtio/vhost.c | 2 +- > hw/virtio/virtio-bus.c | 14 ++++++-------- > hw/virtio/virtio-mmio.c | 18 ------------------ > hw/virtio/virtio-pci.c | 17 ----------------- > hw/virtio/virtio-pci.h | 1 - > include/hw/virtio/virtio-bus.h | 17 +++++++---------- > 10 files changed, 16 insertions(+), 79 deletions(-) Nice amount of code deletion :) Reviewed-by: Cornelia Huck