From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwY8F-00031i-23 for qemu-devel@nongnu.org; Tue, 18 Oct 2016 13:24:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwY8C-0002ho-7I for qemu-devel@nongnu.org; Tue, 18 Oct 2016 13:24:55 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:39363 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwY8C-0002hi-10 for qemu-devel@nongnu.org; Tue, 18 Oct 2016 13:24:52 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9IHOgxP105451 for ; Tue, 18 Oct 2016 13:24:51 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 265j6ve25v-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 18 Oct 2016 13:24:51 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 18 Oct 2016 18:24:49 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id AD75417D805D for ; Tue, 18 Oct 2016 18:26:58 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9IHOlR116384292 for ; Tue, 18 Oct 2016 17:24:47 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9IHOlTX026065 for ; Tue, 18 Oct 2016 11:24:47 -0600 Date: Tue, 18 Oct 2016 19:24:45 +0200 From: Cornelia Huck In-Reply-To: <1476100421-28772-1-git-send-email-pbonzini@redhat.com> References: <1476100421-28772-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20161018192445.413c040d.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com, borntraeger@de.ibm.com, famz@redhat.com, mst@redhat.com On Mon, 10 Oct 2016 13:53:28 +0200 Paolo Bonzini wrote: > This series started as an attempt to always use the dataplane path > for virtio-blk and virtio-scsi when ioeventfd is active. The aim > was three-fold: > > 1) to add more coverage for dataplane > > 2) to remove virtio_add_queue_aio > > 3) to simplify the dataplane start/stop code > > It achieves the first two objectives, and while it doesn't quite > achieve the third it does cleanup the generic ioeventfd code in > virtio-bus more than I expected. In particular, it reduces the set > of callbacks that transports must implement, and it removes the ugly > case where ioeventfd is started with generic callbacks and then moved > to the dataplane callbacks. It also enables some simplification of the > functions that deal with host notifiers, and detects some configuration > errors better. > > I've tested it with virtio-blk, virtio-scsi and vhost-net. Do you have a branch somewhere? > > Patch 1 is a bugfix that I found while testing the TCG+dataplane combo. > > Patches 2 and 3 are simplifications that are too nice to leave > them for later in the series. > > Patch 4 moves some of the ioeventfd code from virtio-bus.c to > virtio.c. At this point the transition is a bit half-assed, but > this changes as soon as we remove the generic->dataplane > handler transition. > > Patches 5 to 7 do exactly that, and then the spring cleaning > begins, lasting for the whole second half of the series. I'll continue to look at the patches from 4 on tomorrow.