From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwn02-0001BC-S6 for qemu-devel@nongnu.org; Wed, 19 Oct 2016 05:17:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwmzz-0005VP-Mz for qemu-devel@nongnu.org; Wed, 19 Oct 2016 05:17:26 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52330) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwmzz-0005TJ-Dc for qemu-devel@nongnu.org; Wed, 19 Oct 2016 05:17:23 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9J9DZgQ052318 for ; Wed, 19 Oct 2016 05:17:22 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2665j71h5h-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 19 Oct 2016 05:17:22 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Oct 2016 10:17:19 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 1106F1B08077 for ; Wed, 19 Oct 2016 10:19:21 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9J9HHtE10027416 for ; Wed, 19 Oct 2016 09:17:17 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9J9HHKH019285 for ; Wed, 19 Oct 2016 05:17:17 -0400 Date: Wed, 19 Oct 2016 11:17:15 +0200 From: Cornelia Huck In-Reply-To: <1476100421-28772-5-git-send-email-pbonzini@redhat.com> References: <1476100421-28772-1-git-send-email-pbonzini@redhat.com> <1476100421-28772-5-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20161019111715.1f21afa0.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 04/13] virtio: add start_ioeventfd and stop_ioeventfd to VirtioDeviceClass List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com, borntraeger@de.ibm.com, famz@redhat.com, mst@redhat.com On Mon, 10 Oct 2016 13:53:32 +0200 Paolo Bonzini wrote: > Allow customization of the start and stop of ioeventfd. This will > allow direct start of dataplane without passing through the default > ioeventfd handlers, which in turn allows using the dataplane logic > instead of virtio_add_queue_aio. It will also enable some code > simplification, because the sole entry point to ioeventfd setup > will be virtio_bus_set_host_notifier. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini > --- > hw/virtio/virtio-bus.c | 55 +++++++++++------------------------- > hw/virtio/virtio.c | 64 ++++++++++++++++++++++++++++++++++++++++++ > include/hw/virtio/virtio-bus.h | 7 ++++- > include/hw/virtio/virtio.h | 4 +++ > 4 files changed, 90 insertions(+), 40 deletions(-) > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 18ce333..3f6005a 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -2120,15 +2120,79 @@ static Property virtio_properties[] = { > DEFINE_PROP_END_OF_LIST(), > }; > > +static int virtio_device_start_ioeventfd_impl(VirtIODevice *vdev) The _impl postfix looks a bit awkward. virtio_device_do_start_ioeventfd? virtio_device_start_ioeventd_internal? (I don't really like these either...) Anyway, Reviewed-by: Cornelia Huck