From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwp1U-0000LP-2O for qemu-devel@nongnu.org; Wed, 19 Oct 2016 07:27:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwp1Q-0006i6-Um for qemu-devel@nongnu.org; Wed, 19 Oct 2016 07:27:04 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:47480 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwp1Q-0006hh-PV for qemu-devel@nongnu.org; Wed, 19 Oct 2016 07:27:00 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9JBOnxb027974 for ; Wed, 19 Oct 2016 07:26:59 -0400 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0b-001b2d01.pphosted.com with ESMTP id 2665wanyvu-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 19 Oct 2016 07:26:59 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Oct 2016 12:26:58 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id B2B4E17D8056 for ; Wed, 19 Oct 2016 12:29:07 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9JBQuPV15269986 for ; Wed, 19 Oct 2016 11:26:56 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9JBQt9r012723 for ; Wed, 19 Oct 2016 05:26:55 -0600 Date: Wed, 19 Oct 2016 13:26:53 +0200 From: Cornelia Huck In-Reply-To: <1476100421-28772-14-git-send-email-pbonzini@redhat.com> References: <1476100421-28772-1-git-send-email-pbonzini@redhat.com> <1476100421-28772-14-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20161019132653.0a9ece97.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 13/13] virtio: inline set_host_notifier_internal List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com, borntraeger@de.ibm.com, famz@redhat.com, mst@redhat.com On Mon, 10 Oct 2016 13:53:41 +0200 Paolo Bonzini wrote: > This is only called from virtio_bus_set_host_notifier. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini > --- > v1->v2: rebase after commit a8bba0a ("virtio: Tell the user what went > wrong when event_notifier_init failed", 2016-09-09) > > hw/virtio/virtio-bus.c | 62 +++++++++++++++++++++----------------------------- > 1 file changed, 26 insertions(+), 36 deletions(-) > > +cleanup_event_notifier: > + /* Test and clear notifier before after disabling event, I always stumble over that "before after" :) > + * in case poll callback didn't have time to run. > + */ > + virtio_queue_host_notifier_read(notifier); > + event_notifier_cleanup(notifier); > + return r; > } > > static char *virtio_bus_get_dev_path(DeviceState *dev) Reviewed-by: Cornelia Huck