From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwpox-0002W4-TK for qemu-devel@nongnu.org; Wed, 19 Oct 2016 08:18:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwpou-0000hs-Oi for qemu-devel@nongnu.org; Wed, 19 Oct 2016 08:18:11 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50532) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwpou-0000gQ-Fb for qemu-devel@nongnu.org; Wed, 19 Oct 2016 08:18:08 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9JCDvmj090921 for ; Wed, 19 Oct 2016 08:18:06 -0400 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 2667qd3bf8-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 19 Oct 2016 08:18:06 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Oct 2016 13:18:03 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id A370617D805D for ; Wed, 19 Oct 2016 13:20:12 +0100 (BST) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9JCI1Ea6094862 for ; Wed, 19 Oct 2016 12:18:01 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9JCI0EG017884 for ; Wed, 19 Oct 2016 06:18:00 -0600 Date: Wed, 19 Oct 2016 14:17:59 +0200 From: Cornelia Huck In-Reply-To: <1476100421-28772-1-git-send-email-pbonzini@redhat.com> References: <1476100421-28772-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20161019141759.67a37694.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com, borntraeger@de.ibm.com, famz@redhat.com, mst@redhat.com On Mon, 10 Oct 2016 13:53:28 +0200 Paolo Bonzini wrote: > This series started as an attempt to always use the dataplane path > for virtio-blk and virtio-scsi when ioeventfd is active. The aim > was three-fold: > > 1) to add more coverage for dataplane > > 2) to remove virtio_add_queue_aio > > 3) to simplify the dataplane start/stop code > > It achieves the first two objectives, and while it doesn't quite > achieve the third it does cleanup the generic ioeventfd code in > virtio-bus more than I expected. In particular, it reduces the set > of callbacks that transports must implement, and it removes the ugly > case where ioeventfd is started with generic callbacks and then moved > to the dataplane callbacks. It also enables some simplification of the > functions that deal with host notifiers, and detects some configuration > errors better. > > I've tested it with virtio-blk, virtio-scsi and vhost-net. Hm. 'make check' on a s390 host faults in check-qtest-aarch64 (your branch rebased to current master; master itself is fine). I'll see if I can find out more (probably later today).