qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: qemu-devel@nongnu.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
	qemu-ppc@nongnu.org, Alexey Kardashevskiy <aik@ozlabs.ru>,
	David Gibson <david@gibson.dropbear.id.au>,
	Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH 1/3] ppc: fix MSR_ME handling for system reset interrupt
Date: Thu, 20 Oct 2016 17:59:10 +1100	[thread overview]
Message-ID: <20161020065912.16132-2-npiggin@gmail.com> (raw)
In-Reply-To: <20161020065912.16132-1-npiggin@gmail.com>

Power ISA specifies ME bit handling for system reset interrupt:

    if the interrupt occurred while the thread was in power-saving
    mode, set to 1; otherwise not altered

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 target-ppc/excp_helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c
index 921c39d..53c4075 100644
--- a/target-ppc/excp_helper.c
+++ b/target-ppc/excp_helper.c
@@ -385,11 +385,11 @@ static inline void powerpc_excp(PowerPCCPU *cpu, int excp_model, int excp)
         srr1 = SPR_BOOKE_CSRR1;
         break;
     case POWERPC_EXCP_RESET:     /* System reset exception                   */
+        /* A power-saving exception sets ME, otherwise it is unchanged */
         if (msr_pow) {
             /* indicate that we resumed from power save mode */
             msr |= 0x10000;
-        } else {
-            new_msr &= ~((target_ulong)1 << MSR_ME);
+            new_msr |= ((target_ulong)1 << MSR_ME);
         }
 
         new_msr |= (target_ulong)MSR_HVB;
-- 
2.9.3

  reply	other threads:[~2016-10-20  6:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20  6:59 [Qemu-devel] (no subject) Nicholas Piggin
2016-10-20  6:59 ` Nicholas Piggin [this message]
2016-10-20 10:23   ` [Qemu-devel] [Qemu-ppc] [PATCH 1/3] ppc: fix MSR_ME handling for system reset interrupt Greg Kurz
2016-10-20 10:23   ` Cédric Le Goater
2016-10-21  1:09   ` [Qemu-devel] " David Gibson
2016-10-21  1:49     ` Nicholas Piggin
2016-10-20  6:59 ` [Qemu-devel] [PATCH 2/3] ppc: allow system reset interrupt to be delivered to guests Nicholas Piggin
2016-10-20 13:08   ` [Qemu-devel] [Qemu-ppc] " Cédric Le Goater
2016-10-20 13:40     ` Nicholas Piggin
2016-10-21  1:09       ` David Gibson
2016-10-21  4:35         ` [Qemu-devel] [PATCH v2] ppc: allow certain HV interrupts " Nicholas Piggin
2016-10-21 10:22           ` Cédric Le Goater
2016-10-24  1:16           ` David Gibson
2016-10-24  6:56             ` Nicholas Piggin
2016-10-25  1:23               ` David Gibson
2016-10-20  6:59 ` [Qemu-devel] [PATCH 3/3] ppc/spapr: implement H_SIGNAL_SYS_RESET Nicholas Piggin
2016-10-20  9:21   ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2016-10-20 13:25     ` Nicholas Piggin
2016-10-20 16:49   ` Greg Kurz
2016-10-21  0:56     ` Nicholas Piggin
2016-10-21  1:21       ` David Gibson
2016-10-20 11:49 ` [Qemu-devel] [Qemu-ppc] (no subject) Greg Kurz
2016-10-20 13:26   ` Nicholas Piggin
2016-10-20 13:19 ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161020065912.16132-2-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).