From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, pbonzini@redhat.com,
peter.maydell@linaro.org, armbru@redhat.com
Subject: [Qemu-devel] [PATCH 0/2] Silence test-vmstate errors
Date: Thu, 20 Oct 2016 11:36:34 +0100 [thread overview]
Message-ID: <20161020103636.22228-1-dgilbert@redhat.com> (raw)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
In a1771070e7 I added an error message during migration loading
so you could see the field that failed to load.
Unfortunately this triggers during the expected-failure case
testing in tests/test-vmstate.
This silences that error by providing a dummy monitor pointer
that doesn't output anything and then selecting it around
the noisy part of the test.
(I couldn't find anywhere better than libqtest.h for the declaration
but stubs doesn't have it's own header; is it worth creating one
just for that?)
Dave
Dr. David Alan Gilbert (2):
tests/stubs: Add a dummy, silent monitor
test-vmstate: Silence expected errors
stubs/mon-is-qmp.c | 9 +++++++++
tests/libqtest.h | 1 +
tests/test-vmstate.c | 8 ++++++++
3 files changed, 18 insertions(+)
--
2.9.3
next reply other threads:[~2016-10-20 10:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 10:36 Dr. David Alan Gilbert (git) [this message]
2016-10-20 10:36 ` [Qemu-devel] [PATCH 1/2] tests/stubs: Add a dummy, silent monitor Dr. David Alan Gilbert (git)
2016-10-20 14:24 ` Eric Blake
2016-10-20 10:36 ` [Qemu-devel] [PATCH 2/2] test-vmstate: Silence expected errors Dr. David Alan Gilbert (git)
2016-10-24 12:55 ` Markus Armbruster
2016-10-24 13:00 ` Paolo Bonzini
2016-10-24 12:59 ` [Qemu-devel] [PATCH 0/2] Silence test-vmstate errors Markus Armbruster
2016-10-24 13:07 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020103636.22228-1-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).