From: Greg Kurz <groug@kaod.org>
To: Alberto Garcia <berto@igalia.com>
Cc: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,
Pradeep Jagadeesh <pradeepkiruvale@gmail.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
qemu-devel@nongnu.org,
Claudio Fontana <claudio.fontana@huawei.com>
Subject: Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices
Date: Thu, 20 Oct 2016 15:32:29 +0200 [thread overview]
Message-ID: <20161020153229.657579cf@bahia> (raw)
In-Reply-To: <w51oa2fp4kq.fsf@maestria.local.igalia.com>
On Thu, 20 Oct 2016 14:50:29 +0200
Alberto Garcia <berto@igalia.com> wrote:
> On Wed 19 Oct 2016 06:29:45 PM CEST, Pradeep Jagadeesh wrote:
>
> > One more update is, I had a look at bdrv_io_limits_intercept and I
> > just removed lock and retained other two things
> > pending_reqs,any_timer_armed It works fine.
>
> So you managed to make it work without the lock? Can you post the new
> version then?
>
> Thanks,
>
> Berto
Pradeep,
Just a reminder: soft freeze is coming (http://wiki.qemu.org/Planning/2.8).
Unless this series is posted/reviewed in time (especially all the issues about
locking and throttling not behaving as expected have been addressed and well
tested), I won't be able to push it to 2.8.
Cheers.
--
Greg
next prev parent reply other threads:[~2016-10-20 13:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 8:33 [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices Pradeep Jagadeesh
2016-09-19 15:41 ` Alberto Garcia
2016-09-20 9:02 ` Pradeep Jagadeesh
2016-09-20 21:56 ` Greg Kurz
2016-09-22 11:29 ` Pradeep Jagadeesh
2016-10-17 9:19 ` Pradeep Jagadeesh
2016-10-18 16:19 ` Alberto Garcia
2016-10-19 8:57 ` Pradeep Jagadeesh
2016-10-19 16:29 ` Pradeep Jagadeesh
2016-10-20 12:50 ` Alberto Garcia
2016-10-20 13:32 ` Greg Kurz [this message]
2016-10-20 13:49 ` Pradeep Jagadeesh
2016-10-20 13:48 ` Pradeep Jagadeesh
2016-09-20 22:15 ` Greg Kurz
2016-09-21 10:22 ` Pradeep Jagadeesh
2016-09-21 12:10 ` Greg Kurz
2016-09-22 11:46 ` Pradeep Jagadeesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020153229.657579cf@bahia \
--to=groug@kaod.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=berto@igalia.com \
--cc=claudio.fontana@huawei.com \
--cc=pradeep.jagadeesh@huawei.com \
--cc=pradeepkiruvale@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).