From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58825)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1bxDSh-0005tF-3J
	for qemu-devel@nongnu.org; Thu, 20 Oct 2016 09:32:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1bxDSc-0007la-I1
	for qemu-devel@nongnu.org; Thu, 20 Oct 2016 09:32:47 -0400
Received: from 10.mo1.mail-out.ovh.net ([178.32.96.102]:54303)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <groug@kaod.org>) id 1bxDSc-0007jo-By
	for qemu-devel@nongnu.org; Thu, 20 Oct 2016 09:32:42 -0400
Received: from player726.ha.ovh.net (b7.ovh.net [213.186.33.57])
	by mo1.mail-out.ovh.net (Postfix) with ESMTP id 9550615FDD
	for <qemu-devel@nongnu.org>; Thu, 20 Oct 2016 15:32:39 +0200 (CEST)
Date: Thu, 20 Oct 2016 15:32:29 +0200
From: Greg Kurz <groug@kaod.org>
Message-ID: <20161020153229.657579cf@bahia>
In-Reply-To: <w51oa2fp4kq.fsf@maestria.local.igalia.com>
References: <1474014817-41572-1-git-send-email-pradeep.jagadeesh@huawei.com>
	<w51k2e7ucc1.fsf@maestria.local.igalia.com>
	<161e02dc-2358-cd62-46b8-5f5d4eca6b67@huawei.com>
	<w51zim1hboy.fsf@maestria.local.igalia.com>
	<37f6452a-aa29-1cac-fde6-31d53e11449f@huawei.com>
	<w51oa2fp4kq.fsf@maestria.local.igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev
 devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>
Cc: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>, Pradeep Jagadeesh <pradeepkiruvale@gmail.com>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Claudio Fontana <claudio.fontana@huawei.com>

On Thu, 20 Oct 2016 14:50:29 +0200
Alberto Garcia <berto@igalia.com> wrote:

> On Wed 19 Oct 2016 06:29:45 PM CEST, Pradeep Jagadeesh wrote:
> 
> > One more update is, I had a look at bdrv_io_limits_intercept and I
> > just removed lock and retained other two things
> > pending_reqs,any_timer_armed It works fine.  
> 
> So you managed to make it work without the lock? Can you post the new
> version then?
> 
> Thanks,
> 
> Berto

Pradeep,

Just a reminder: soft freeze is coming (http://wiki.qemu.org/Planning/2.8).
Unless this series is posted/reviewed in time (especially all the issues about
locking and throttling not behaving as expected have been addressed and well
tested), I won't be able to push it to 2.8.

Cheers.

--
Greg