From: "Daniel P. Berrange" <berrange@redhat.com>
To: Pino Toscano <ptoscano@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, kwolf@redhat.com,
jcody@redhat.com, rjones@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] ssh: switch from libssh2 to libssh
Date: Fri, 21 Oct 2016 12:25:40 +0100 [thread overview]
Message-ID: <20161021112539.GM6585@redhat.com> (raw)
In-Reply-To: <1477048571-29592-1-git-send-email-ptoscano@redhat.com>
On Fri, Oct 21, 2016 at 01:16:11PM +0200, Pino Toscano wrote:
> Rewrite the implementation of the ssh block driver to use libssh instead
> of libssh2. The libssh library has various advantages over libssh2:
> - easier API for authentication (for example for using ssh-agent)
> - easier API for known_hosts handling
> - supports newer types of keys in known_hosts
>
> Kerberos authentication can be enabled once the libssh bug for it [1] is
> fixed.
IIUC from the code this relies on QEMU being able to talk to an ssh
agent to do public key auth. Is there a way to directly provide the
passphase for the private key (avoiding need for an agent), or to
provide a plani password to libssh ?
If so, you could use the QEMU 'secret' object type to provide these
passphrases & passwords to QEMU, which can in turn pass them to
libssh.
Avoiding the need for ssh agent in this way would make it possible
to use this driver with libvirt in more circumstances.
eg for plain passwords you could do
$QEMU -object secret,id=sec0,data=mypassword
-drive driver=ssh,....,password-secret=sec0
while for private key passphrases
$QEMU -object secret,id=sec0,data=mypassphrase
-drive driver=ssh,....,key-passphrase-secret=sec0
No need to do this all as part of this patch though - it'd be cleaner to
do this as a separate patch
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
next prev parent reply other threads:[~2016-10-21 11:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 11:16 [Qemu-devel] [PATCH v2] ssh: switch from libssh2 to libssh Pino Toscano
2016-10-21 11:25 ` Daniel P. Berrange [this message]
2016-10-21 15:28 ` Pino Toscano
2016-10-21 12:02 ` Richard W.M. Jones
2016-10-21 15:30 ` Pino Toscano
2016-10-21 15:39 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021112539.GM6585@redhat.com \
--to=berrange@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=ptoscano@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).