From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxYWs-0008EF-7s for qemu-devel@nongnu.org; Fri, 21 Oct 2016 08:02:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxYWr-00046c-CI for qemu-devel@nongnu.org; Fri, 21 Oct 2016 08:02:30 -0400 Date: Fri, 21 Oct 2016 13:02:21 +0100 From: "Richard W.M. Jones" Message-ID: <20161021120221.GK11243@redhat.com> References: <1477048571-29592-1-git-send-email-ptoscano@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477048571-29592-1-git-send-email-ptoscano@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] ssh: switch from libssh2 to libssh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pino Toscano Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, jcody@redhat.com, kwolf@redhat.com, mreitz@redhat.com On Fri, Oct 21, 2016 at 01:16:11PM +0200, Pino Toscano wrote: > Rewrite the implementation of the ssh block driver to use libssh instead > of libssh2. The libssh library has various advantages over libssh2: > - easier API for authentication (for example for using ssh-agent) > - easier API for known_hosts handling > - supports newer types of keys in known_hosts > > Kerberos authentication can be enabled once the libssh bug for it [1] is > fixed. > > The development version of libssh (i.e. the future 0.8.x) supports > fsync, so reuse the build time check for this. > > [1] https://red.libssh.org/issues/242 > > Signed-off-by: Pino Toscano > --- > > Changes from v1: > - fixed jumbo packets writing > - fixed missing 'err' assignment > - fixed commit message This version works, but I also switched from using a remote server to using this over localhost. It seems as if the timeout might be a bit short. Could that be made controllable? Or increased to match whatever libssh2 was using? I couldn't see any other problems in the patch itself. knownhost and ssh-agent handling certainly seems much simpler :-) Before I forget, there's another problem we found with the old ssh driver: It cannot open a device on the remote side, eg. if you used: `file.driver=ssh,file.path=/dev/sdX' I suspect this is not solvable on the client side, it requires changes to sshd. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org