From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59280)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1bxaZ6-0004op-Ki
	for qemu-devel@nongnu.org; Fri, 21 Oct 2016 10:12:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1bxaZ1-0007M3-Li
	for qemu-devel@nongnu.org; Fri, 21 Oct 2016 10:12:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38598)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <imammedo@redhat.com>) id 1bxaZ1-0007Lf-Ga
	for qemu-devel@nongnu.org; Fri, 21 Oct 2016 10:12:51 -0400
Date: Fri, 21 Oct 2016 16:12:47 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20161021161247.14cbb12e@nial.brq.redhat.com>
In-Reply-To: <20161021082801.dglwfsocljohquok@hz-desktop>
References: <20161021082801.dglwfsocljohquok@hz-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Regression caused by d2f39ad "exec.c: Ensure right
 alignment also for file backed ram"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Haozhong Zhang <haozhong.zhang@intel.com>
Cc: qemu-devel@nongnu.org, chao.p.peng@intel.com, Eduardo Habkost <ehabkost@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Dominik Dingel <dingel@linux.vnet.ibm.com>, anthony.xu@intel.com, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>

On Fri, 21 Oct 2016 16:28:01 +0800
Haozhong Zhang <haozhong.zhang@intel.com> wrote:

> Hi,
> 
> Commit d2f39ad "exec.c: Ensure right alignment also for file backed
> ram" added an additional alignment requirement besides to the previous
> page size for the size of the backend file. On x86, the alignment
> requirement for the size of the backend file is changed from 4KB in
> QEMU 2.6 to 2MB in QEMU 2.7.
> 
> This change immediately breaks the usage of "-object memory-backend-file,...,size=$SIZE"
> on x86, where $SIZE is multiple of 4KB but not 2MB. It works on QEMU 2.6.
> Could this be considered as a regression?
> 
> The commit message shows it's for s390. I'm wondering whether the same
> regression happens on s390 and ARM. If not, could I fix the regression
> on x86 by keeping using the original alignment only on x86, e.g.
> 
> modified   exec.c
> @@ -1254,7 +1254,11 @@ static void *file_ram_alloc(RAMBlock *block,
>      }
>  
>      block->page_size = qemu_fd_getpagesize(fd);
> +#if defined(__x86_64__) || defined(__i386__)
SPAPR supports mem hotplug so it's also affected

> +    block->mr->align = block->page_size;
> +#else
>      block->mr->align = MAX(block->page_size, QEMU_VMALLOC_ALIGN);
> +#endif
>  
>      if (memory < block->page_size) {
>          error_setg(errp, "memory size 0x" RAM_ADDR_FMT " must be equal to "
> 
> 
> Thanks,
> Haozhong
>