qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH 24/38] char: move fe_open in CharBackend
Date: Sat, 22 Oct 2016 13:09:37 +0300	[thread overview]
Message-ID: <20161022100951.19562-1-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20161022095318.17775-1-marcandre.lureau@redhat.com>

The fe_open state belongs to front end.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 qemu-char.c           | 7 ++++---
 include/sysemu/char.h | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/qemu-char.c b/qemu-char.c
index e52c3af..81a593b 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -921,6 +921,7 @@ bool qemu_chr_fe_init(CharBackend *b, CharDriverState *s, Error **errp)
         s->be = b;
     }
 
+    b->fe_open = false;
     b->tag = tag;
     b->chr = s;
 
@@ -4221,10 +4222,10 @@ void qemu_chr_fe_set_open(CharBackend *be, int fe_open)
         return;
     }
 
-    if (chr->fe_open == fe_open) {
+    if (be->fe_open == fe_open) {
         return;
     }
-    chr->fe_open = fe_open;
+    be->fe_open = fe_open;
     if (chr->chr_set_fe_open) {
         chr->chr_set_fe_open(chr, fe_open);
     }
@@ -4309,7 +4310,7 @@ ChardevInfoList *qmp_query_chardev(Error **errp)
         info->value = g_malloc0(sizeof(*info->value));
         info->value->label = g_strdup(chr->label);
         info->value->filename = g_strdup(chr->filename);
-        info->value->frontend_open = chr->fe_open;
+        info->value->frontend_open = chr->be && chr->be->fe_open;
 
         info->next = chr_list;
         chr_list = info;
diff --git a/include/sysemu/char.h b/include/sysemu/char.h
index ae32e1c..2c3060c 100644
--- a/include/sysemu/char.h
+++ b/include/sysemu/char.h
@@ -81,6 +81,7 @@ typedef struct CharBackend {
     IOReadHandler *chr_read;
     void *opaque;
     int tag;
+    int fe_open;
 } CharBackend;
 
 struct CharDriverState {
@@ -108,7 +109,6 @@ struct CharDriverState {
     char *filename;
     int logfd;
     int be_open;
-    int fe_open;
     int explicit_be_open;
     int avail_connections;
     int is_mux;
-- 
2.10.0

  parent reply	other threads:[~2016-10-22 10:10 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-22  9:52 [Qemu-devel] [PATCH 00/38] char: fixes and improvements (was "[PATCH 0/9] Fix mux regression") Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 01/38] rng: remove unused included header Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 02/38] char: remove use-after-free on win-stdio Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 03/38] ringbuf: fix chr_write return value Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 04/38] sun4uv: fix serial initialization regression Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 05/38] malta: replace chr init by CHR_EVENT_OPENED handler Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 06/38] char: remove init callback Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 07/38] xilinx: fix buffer overflow on realize Marc-André Lureau
2016-10-23 12:01   ` Paolo Bonzini
2016-10-22  9:52 ` [Qemu-devel] [PATCH 08/38] mux: split mux_chr_update_read_handler() Marc-André Lureau
2016-10-24 19:51   ` Eric Blake
2016-10-22  9:52 ` [Qemu-devel] [PATCH 09/38] char: introduce CharBackend Marc-André Lureau
2016-10-23 12:03   ` Paolo Bonzini
2016-10-22  9:52 ` [Qemu-devel] [PATCH 10/38] char: start converting mux driver to use CharBackend Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 11/38] char: replace PROP_CHR with CharBackend Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 12/38] char: remaining switch to CharBackend in frontend Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 13/38] char: rename some frontend functions Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 14/38] colo: claim in find_and_check_chardev Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 15/38] char: use qemu_chr_fe* functions with CharBackend argument Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 16/38] char: fold qemu_chr_set_handlers in qemu_chr_fe_set_handlers Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 17/38] vhost-user: only initialize queue 0 CharBackend Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 18/38] char: replace qemu_chr_claim/release with qemu_chr_fe_init/deinit Marc-André Lureau
2016-10-22  9:52 ` [Qemu-devel] [PATCH 19/38] char: make some qemu_chr_fe skip if no driver Marc-André Lureau
2023-02-15 22:13   ` Philippe Mathieu-Daudé
2023-02-16 14:23     ` Marc-André Lureau
2023-02-16 15:29       ` Philippe Mathieu-Daudé
2016-10-22  9:53 ` [Qemu-devel] [PATCH 20/38] tests: start chardev unit tests Marc-André Lureau
2016-10-27 18:27   ` Eric Blake
2016-10-22  9:53 ` [Qemu-devel] [PATCH 21/38] char: move front end handlers in CharBackend Marc-André Lureau
2016-10-24 13:40   ` Paolo Bonzini
2016-10-22  9:53 ` [Qemu-devel] [PATCH 22/38] char: rename chr_close/chr_free Marc-André Lureau
2016-10-22  9:53 ` [Qemu-devel] [PATCH 23/38] char: remove explicit_fe_open, use a set_handlers argument Marc-André Lureau
2016-10-22 10:09 ` Marc-André Lureau [this message]
2016-10-22 10:09   ` [Qemu-devel] [PATCH 25/38] char: remove unused CHR_EVENT_FOCUS Marc-André Lureau
2016-10-22 10:09   ` [Qemu-devel] [PATCH 26/38] char: use an enum for CHR_EVENT Marc-André Lureau
2016-10-22 10:09   ` [Qemu-devel] [PATCH 27/38] char: remove unused qemu_chr_fe_event Marc-André Lureau
2016-10-22 10:09   ` [Qemu-devel] [PATCH 28/38] char: replace avail_connections Marc-André Lureau
2016-10-22 10:09   ` [Qemu-devel] [PATCH 29/38] char: use common error path in qmp_chardev_add Marc-André Lureau
2016-10-22 10:09   ` [Qemu-devel] [PATCH 30/38] char: remove explicit_be_open from CharDriverState Marc-André Lureau
2016-10-22 10:09   ` [Qemu-devel] [PATCH 31/38] char: use a const CharDriver Marc-André Lureau
2016-10-23 12:24     ` Paolo Bonzini
2016-10-22 10:09   ` [Qemu-devel] [PATCH 32/38] char: use a static array for backends Marc-André Lureau
2016-10-23 12:21     ` Paolo Bonzini
2016-10-22 10:09   ` [Qemu-devel] [PATCH 33/38] char: move callbacks in CharDriver Marc-André Lureau
2016-10-22 10:09   ` [Qemu-devel] [PATCH 34/38] char: fold single-user functions in caller Marc-André Lureau
2016-10-22 10:09   ` [Qemu-devel] [PATCH 35/38] char: introduce generic qemu_chr_get_kind() Marc-André Lureau
2016-10-22 10:09   ` [Qemu-devel] [PATCH 36/38] char: use a feature bit for replay Marc-André Lureau
2016-10-22 10:16 ` [Qemu-devel] [PATCH 37/38] char: allocate CharDriverState as a single object Marc-André Lureau
2016-10-22 10:16   ` [Qemu-devel] [PATCH 38/38] bt: use qemu_chr_alloc() Marc-André Lureau
2016-10-23 12:28   ` [Qemu-devel] [PATCH 37/38] char: allocate CharDriverState as a single object Paolo Bonzini
2016-10-23 18:15 ` [Qemu-devel] [PATCH 00/38] char: fixes and improvements (was "[PATCH 0/9] Fix mux regression") Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161022100951.19562-1-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).