From: David Gibson <david@gibson.dropbear.id.au>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
qemu-devel <qemu-devel@nongnu.org>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>
Subject: Re: [Qemu-devel] target-ppc: gdbstub breakpoints get stuck in an infinite loop on next/continue
Date: Mon, 24 Oct 2016 12:00:55 +1100 [thread overview]
Message-ID: <20161024010055.GC19629@umbus.fritz.box> (raw)
In-Reply-To: <b94872bf-d4a6-2ce1-184c-29e5e9f7283b@ilande.co.uk>
[-- Attachment #1: Type: text/plain, Size: 2097 bytes --]
On Sat, Oct 22, 2016 at 09:22:45AM +0100, Mark Cave-Ayland wrote:
> On 21/10/16 23:02, Benjamin Herrenschmidt wrote:
>
> > On Fri, 2016-10-21 at 15:18 +0100, Mark Cave-Ayland wrote:
> >>
> >> bd6fefe71cec5a0c7d2be4ac96307f25db56abf9 is the first bad commit
> >> commit bd6fefe71cec5a0c7d2be4ac96307f25db56abf9
> >> Author: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> >> Date: Wed Jul 27 16:56:32 2016 +1000
> >>
> >> ppc: Make tlb_fill() use new exception helper
> >>
> >> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> >> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> >>
> >> :040000 040000 3494b2d68eef71c8f7c7d4e57c5ff715146028b2
> >> 00849bf5889d8ee5b5ce633122b7aedf4a734372 M linux-user
> >> :040000 040000 32b1a8078a44c44e6bfd2184061b6da553cfc821
> >> 58afefec7a9fc5380fb408758a11dbe749010b97 M target-ppc
> >
> > Hrm, that patch does a lot more that the subject (and lack of cset
> > comment) implies. I wonder if it got some rebase damage here.
>
> Indeed, it looks like extra changes were squashed into that single patch
> between these two pull requests:
>
> 6th September:
> https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg00887.html
>
> 7th September:
> https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg01465.html
Crap. Yeah, looks like a screwed up a rebase.
> > In the meantime, look at 24a2d2ac2cfbb699cab216aaf118c8503f22817c
> > " ppc: Fix single step with gdb stub" in my wip branch, see if that
> > helps.
>
> Yes it does - I've cherry-picked this onto master and I can confirm that
> it fixes the gdbstub issues I was seeing here.
>
> David, any chance we can we get this queued into your ppc-for-2.8 branch?
Done.
Ben, does it look like the other extraneous changes in bd6fefe are at
least correct, apart from being in the wrong patch?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-10-24 1:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 14:18 [Qemu-devel] target-ppc: gdbstub breakpoints get stuck in an infinite loop on next/continue Mark Cave-Ayland
2016-10-21 22:02 ` Benjamin Herrenschmidt
2016-10-22 8:22 ` Mark Cave-Ayland
2016-10-24 1:00 ` David Gibson [this message]
2016-10-24 20:08 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024010055.GC19629@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=benh@kernel.crashing.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).