From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byTnJ-0005cv-46 for qemu-devel@nongnu.org; Sun, 23 Oct 2016 21:11:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byTnG-0002fT-0r for qemu-devel@nongnu.org; Sun, 23 Oct 2016 21:11:17 -0400 Date: Mon, 24 Oct 2016 12:00:55 +1100 From: David Gibson Message-ID: <20161024010055.GC19629@umbus.fritz.box> References: <7e2d79de-5e4b-6140-63e1-f6829d834b4a@ilande.co.uk> <1477087365.2430.3.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sHrvAb52M6C8blB9" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] target-ppc: gdbstub breakpoints get stuck in an infinite loop on next/continue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: Benjamin Herrenschmidt , qemu-devel , "qemu-ppc@nongnu.org" --sHrvAb52M6C8blB9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 22, 2016 at 09:22:45AM +0100, Mark Cave-Ayland wrote: > On 21/10/16 23:02, Benjamin Herrenschmidt wrote: >=20 > > On Fri, 2016-10-21 at 15:18 +0100, Mark Cave-Ayland wrote: > >> =20 > >> bd6fefe71cec5a0c7d2be4ac96307f25db56abf9 is the first bad commit > >> commit bd6fefe71cec5a0c7d2be4ac96307f25db56abf9 > >> Author: Benjamin Herrenschmidt > >> Date: Wed Jul 27 16:56:32 2016 +1000 > >> > >> ppc: Make tlb_fill() use new exception helper > >> > >> Signed-off-by: Benjamin Herrenschmidt > >> Signed-off-by: David Gibson > >> > >> :040000 040000 3494b2d68eef71c8f7c7d4e57c5ff715146028b2 > >> 00849bf5889d8ee5b5ce633122b7aedf4a734372 M linux-user > >> :040000 040000 32b1a8078a44c44e6bfd2184061b6da553cfc821 > >> 58afefec7a9fc5380fb408758a11dbe749010b97 M target-ppc > >=20 > > Hrm, that patch does a lot more that the subject (and lack of cset > > comment) implies. I wonder if it got some rebase damage here. >=20 > Indeed, it looks like extra changes were squashed into that single patch > between these two pull requests: >=20 > 6th September: > https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg00887.html >=20 > 7th September: > https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg01465.html Crap. Yeah, looks like a screwed up a rebase. > > In the meantime, look at 24a2d2ac2cfbb699cab216aaf118c8503f22817c > > " ppc: Fix single step with gdb stub" in my wip branch, see if that > > helps. >=20 > Yes it does - I've cherry-picked this onto master and I can confirm that > it fixes the gdbstub issues I was seeing here. >=20 > David, any chance we can we get this queued into your ppc-for-2.8 branch? Done. Ben, does it look like the other extraneous changes in bd6fefe are at least correct, apart from being in the wrong patch? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --sHrvAb52M6C8blB9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYDV1EAAoJEGw4ysog2bOSRIQQAJvV/3PY0nVcGvxDw8blX6RK HlrsjInHtAKbUQpZ8fp0rj27Svq8O6rj2eKRybJrgq4fhi6oyFk8s720RXfRTNpI zA033OlwR83OZr+UFR4Lrt1NoZka4hAvILZptgIfjeHhaK31+8WGNKajG4OwxRyC P/YWRB0OtRxrDRhRtoDRSAjImDtNBYB/HrTdH+7DJwkYCduVFWxWXNuTopZ5rL+e UWL8uuhEfxH3cqNJP7VZ64qSIDN3p1hq1jBDXCyeAJgk7VBLOk9dafRnU1JOdnKN oai5q4aeEKs6RI/e+eJwG6Dun+QicAdhSLW5rxIfb74C9COsMpuXWJS6G7oUftF1 tgdwDrdhwXcBO06rEvftiE2GCVJb0SA0w6k2JbJyWqkAQ3ROvISLA/S25+7ZntL9 1Y//tgwXO2mcile14hnc0/W+ZcCk5+7RtgyAuF2CZqWgfd41KAOBd7Bd4rzm8hjy A6wLFbTlWtgUCBIB6Q8idbKBZld9dHjk2Bgs+PilO3HK5qeaW0t/rvpr4xCePPlE Ace28fwyifImTf/njxRWbYGreJtdrG28ZQgpTzs93M5nSK3VEAe66yiURwAentXJ yyvyPwpsUF5WyPb5DCCa6SuYbylmN1SiFA/2yfIptSRZcCsFQK8lM8S1tq3n7d+L mBrbEyi+Z6jzXhaqBjq3 =nW7W -----END PGP SIGNATURE----- --sHrvAb52M6C8blB9--