From: Alex Williamson <alex.williamson@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Thorsten Kohfeldt <thorsten.kohfeldt@gmx.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH] memory: Don't use memcpy for ram marked as skip_dump
Date: Mon, 24 Oct 2016 09:16:47 -0600 [thread overview]
Message-ID: <20161024091647.1ef0a8fe@t450s.home> (raw)
In-Reply-To: <4e5b9816-d845-a502-8737-572b0cb638b8@redhat.com>
On Mon, 24 Oct 2016 13:05:56 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 22/10/2016 17:09, Alex Williamson wrote:
> > > Add a trace message for each mrop.
> >
> > Yes, this is on my todo list post-RFC.
>
> Another thing to think about:
>
> 1) rename all the skip_dump occurrences in the API to device_memory.
> The new ops make it much more specific than just skipping the region
> during dumps.
>
> 2) get rid of mr->skip_dump and check mr->ops == &skip_dump_ops (or
> device_memory_ops) instead.
Yep, I like those ideas. Thanks,
Alex
next prev parent reply other threads:[~2016-10-24 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 17:11 [Qemu-devel] [RFC PATCH] memory: Don't use memcpy for ram marked as skip_dump Alex Williamson
2016-10-22 9:10 ` Thorsten Kohfeldt
2016-10-22 15:09 ` Alex Williamson
2016-10-24 11:05 ` Paolo Bonzini
2016-10-24 15:16 ` Alex Williamson [this message]
2016-10-24 21:40 ` Thorsten Kohfeldt
2016-10-22 9:14 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024091647.1ef0a8fe@t450s.home \
--to=alex.williamson@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thorsten.kohfeldt@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).